Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc

Issue 2737953002: UKM: Remove UkmService::RecordSource (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ukm/test_ukm_service.h » ('j') | components/ukm/ukm_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
index e5bf87d86105f263d3d4c366d057e3f0fa5365d6..c105f53adf48eeba3cd683650896dae13c271536 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
@@ -43,8 +43,17 @@ class UkmPageLoadMetricsObserverTest
}
const ukm::UkmSource* GetUkmSource(size_t source_index) {
- return ukm_service_test_harness_.test_ukm_service()->GetSource(
- source_index);
+ // This relies on the fact that new UKM source ID values are increasing,
+ // otherwise, there is no way to reason about the ordering.
+ const std::map<int32_t, std::unique_ptr<ukm::UkmSource>>& sources =
rkaplow 2017/03/08 18:49:20 auto?
Zhen Wang 2017/03/08 19:25:51 Done.
+ ukm_service_test_harness_.test_ukm_service()->GetSources();
+ size_t index = 0;
+ for (const auto& kv : sources) {
+ if (index == source_index)
+ return kv.second.get();
+ index++;
+ }
+ return nullptr;
}
const ukm::UkmEntry* GetUkmEntry(size_t entry_index) {
« no previous file with comments | « no previous file | components/ukm/test_ukm_service.h » ('j') | components/ukm/ukm_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698