UKM: Remove UkmService::RecordSource

components/ukm/ukm_service.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UKM_UKM_SERVICE_H_
 #define COMPONENTS_UKM_UKM_SERVICE_H_
 
 #include <stddef.h>
 #include <memory>
 #include <vector>
@@ skipping 81 matching lines @@
   void RegisterMetricsProvider(
       std::unique_ptr<metrics::MetricsProvider> provider);
 
   // Registers the names of all of the preferences used by UkmService in
   // the provided PrefRegistry.
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
   using AddEntryCallback = base::Callback<void(std::unique_ptr<UkmEntry>)>;
 
  protected:
-  const std::vector<std::unique_ptr<UkmSource>>& sources_for_testing() const {
+  const std::map<int32_t, std::unique_ptr<UkmSource>>& sources_for_testing()
+      const {
     return sources_;
   }
 
   const std::vector<std::unique_ptr<UkmEntry>>& entries_for_testing() const {
     return entries_;
   }
 
  private:
   friend UkmPageLoadMetricsObserver;
   friend autofill::AutofillMetrics;
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, AddEntryOnlyWithNonEmptyMetrics);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, EntryBuilderAndSerialization);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest,
                            LogsUploadedOnlyWhenHavingSourcesOrEntries);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, MetricsProviderTest);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, PersistAndPurge);
 
   // Get a new UkmEntryBuilder object for the specified source ID and event,
   // which can get metrics added to.
   //
   // This API being private is intentional. Any client using UKM needs to
   // declare itself to be a friend of UkmService and go through code review
   // process.
   std::unique_ptr<UkmEntryBuilder> GetEntryBuilder(int32_t source_id,
                                                    const char* event_name);
 
-  // Adds a new source of UKM metrics, which will be stored until periodically
-  // serialized for upload, and then deleted. This method is deprecated. Please
-  // use GetEntryBuilder and UpdateSourceURL above.
-  void RecordSource(std::unique_ptr<UkmSource> source);
-
   // Starts metrics client initialization.
   void StartInitTask();
 
   // Called when initialization tasks are complete, to notify the scheduler
   // that it can begin calling RotateLog.
   void FinishedInitTask();
 
   // Periodically called by scheduler_ to advance processing of logs.
   void RotateLog();
 
@@ skipping 39 matching lines @@
 
   // Instance of the helper class for uploading logs.
   std::unique_ptr<metrics::MetricsLogUploader> log_uploader_;
 
   bool initialize_started_;
   bool initialize_complete_;
   bool log_upload_in_progress_;
 
   // Contains newly added sources and entries of UKM metrics which periodically
   // get serialized and cleared by BuildAndStoreLog().
-  // TODO(zhenw): update sources to a map keyed by source ID.
-  std::vector<std::unique_ptr<UkmSource>> sources_;
+  std::map<int32_t, std::unique_ptr<UkmSource>> sources_;
   std::vector<std::unique_ptr<UkmEntry>> entries_;
 
   // Weak pointers factory used to post task on different threads. All weak
   // pointers managed by this factory have the same lifetime as UkmService.
   base::WeakPtrFactory<UkmService> self_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(UkmService);
 };
 
 }  // namespace ukm
 
 #endif  // COMPONENTS_UKM_UKM_SERVICE_H_