Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: ios/web/web_state/web_state_impl.mm

Issue 2737943003: Moved window opening callback to WebStateDelegate. (Closed)
Patch Set: Self review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_state_impl.mm
diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm
index 309b809dfd28fb461f124cdfd4c1ab908903b056..ff8e9f63af192136451e8773c02a52216d54391d 100644
--- a/ios/web/web_state/web_state_impl.mm
+++ b/ios/web/web_state/web_state_impl.mm
@@ -506,6 +506,16 @@ void WebStateImpl::RunJavaScriptDialog(
message_text, default_prompt_text, callback);
}
+WebState* WebStateImpl::CreateNewWebState(const GURL& url,
+ const GURL& opener_url,
+ bool initiated_by_user) {
+ if (delegate_) {
+ return delegate_->CreateNewWebState(this, url, opener_url,
+ initiated_by_user);
+ }
+ return nullptr;
+}
+
void WebStateImpl::OnAuthRequired(
NSURLProtectionSpace* protection_space,
NSURLCredential* proposed_credential,

Powered by Google App Engine
This is Rietveld 408576698