Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27379002: Added explicit default values to AttestationSettingsProto. (Closed)

Created:
7 years, 2 months ago by Darren Krahn
Modified:
7 years, 2 months ago
Reviewers:
bartfab (slow), dkalin
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Added explicit default values to AttestationSettingsProto. This change has no effect on client behavior but is desirable for robustness on the server side. BUG=None TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229460

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/policy/proto/chromeos/chrome_device_policy.proto View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Darren Krahn
CC: dkalin
7 years, 2 months ago (2013-10-15 18:13:23 UTC) #1
bartfab (slow)
lgtm
7 years, 2 months ago (2013-10-16 12:54:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27379002/1
7 years, 2 months ago (2013-10-16 18:15:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27379002/1
7 years, 2 months ago (2013-10-16 21:57:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27379002/1
7 years, 2 months ago (2013-10-17 01:55:14 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-17 06:52:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27379002/47001
7 years, 2 months ago (2013-10-17 17:06:04 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-17 18:29:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27379002/47001
7 years, 2 months ago (2013-10-17 19:41:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27379002/47001
7 years, 2 months ago (2013-10-18 01:42:19 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-18 20:22:45 UTC) #11
Message was sent while issue was closed. 
Change committed as 229460

Powered by Google App Engine
This is Rietveld 408576698