third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp - Issue 2737883002: Rename LayoutPart::widget to LayoutPart::frameViewBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2737883002: Rename LayoutPart::widget to LayoutPart::frameViewBase (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

index 32cae1d7439160baa71b9fb624f553e0612029a7..253107f184de62e77d9bbc9c76626d435cb1cbd0 100644

--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

@@ -665,10 +665,10 @@ TEST_P(ScrollingCoordinatorTest, iframeScrolling) {

LayoutPart* layoutPart = toLayoutPart(layoutObject);

ASSERT_TRUE(layoutPart);

- ASSERT_TRUE(layoutPart->widget());

- ASSERT_TRUE(layoutPart->widget()->isFrameView());

+ ASSERT_TRUE(layoutPart->frameViewBase());

+ ASSERT_TRUE(layoutPart->frameViewBase()->isFrameView());

- FrameView* innerFrameView = toFrameView(layoutPart->widget());

+ FrameView* innerFrameView = toFrameView(layoutPart->frameViewBase());

LayoutViewItem innerLayoutViewItem = innerFrameView->layoutViewItem();

ASSERT_FALSE(innerLayoutViewItem.isNull());

@@ -716,10 +716,10 @@ TEST_P(ScrollingCoordinatorTest, rtlIframe) {

LayoutPart* layoutPart = toLayoutPart(layoutObject);

ASSERT_TRUE(layoutPart);

- ASSERT_TRUE(layoutPart->widget());

- ASSERT_TRUE(layoutPart->widget()->isFrameView());

+ ASSERT_TRUE(layoutPart->frameViewBase());

+ ASSERT_TRUE(layoutPart->frameViewBase()->isFrameView());

- FrameView* innerFrameView = toFrameView(layoutPart->widget());

+ FrameView* innerFrameView = toFrameView(layoutPart->frameViewBase());

LayoutViewItem innerLayoutViewItem = innerFrameView->layoutViewItem();

ASSERT_FALSE(innerLayoutViewItem.isNull());

@@ -893,10 +893,10 @@ TEST_P(ScrollingCoordinatorTest,

LayoutPart* layoutPart = toLayoutPart(layoutObject);

ASSERT_TRUE(layoutPart);

- ASSERT_TRUE(layoutPart->widget());

- ASSERT_TRUE(layoutPart->widget()->isFrameView());

+ ASSERT_TRUE(layoutPart->frameViewBase());

+ ASSERT_TRUE(layoutPart->frameViewBase()->isFrameView());

- FrameView* innerFrameView = toFrameView(layoutPart->widget());

+ FrameView* innerFrameView = toFrameView(layoutPart->frameViewBase());

LayoutViewItem innerLayoutViewItem = innerFrameView->layoutViewItem();

ASSERT_FALSE(innerLayoutViewItem.isNull());

« third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp ('K') | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »