Avoid dependency on unspecified evaluation order of parameters.

components/ntp_tiles/icon_cacher_impl.cc

Index: components/ntp_tiles/icon_cacher_impl.cc
diff --git a/components/ntp_tiles/icon_cacher_impl.cc b/components/ntp_tiles/icon_cacher_impl.cc
index 6c7076f85fa247e0e62d5fcdc0aae87f769412db..f9ac31869e7cf0fd3ff9a194262cb7f145a57ea6 100644
--- a/components/ntp_tiles/icon_cacher_impl.cc
+++ b/components/ntp_tiles/icon_cacher_impl.cc
@@ -49,8 +49,14 @@ void IconCacherImpl::StartFetch(
     PopularSites::Site site,
     const base::Closure& icon_available,
     const base::Closure& preliminary_icon_available) {
+  // From [5.2.2] of the standard, "the order of evaluation of arguments is
+  // unspecified. All side effects of argument expression evaluations take
+  // effect before the function is entered" so copy values from |site| before
+  // it is moved.

[sfiera, 2017/03/08 09:38:54]

I think "copy values from |site| before it is moved" is enough of a comment
here.

[sdefresne, 2017/03/08 18:35:35]

Done.

+  GURL site_url = site.url;
+  favicon_base::IconType icon_type = IconType(site);
   favicon::GetFaviconImageForPageURL(
-      favicon_service_, site.url, IconType(site),
+      favicon_service_, site_url, icon_type,
       base::Bind(&IconCacherImpl::OnGetFaviconImageForPageURLFinished,
                  base::Unretained(this), std::move(site), icon_available,
                  preliminary_icon_available),