third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2737843003: [css-align] Implement place-items alignment shorthand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2737843003: [css-align] Implement place-items alignment shorthand (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html ('K') | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/css/StylePropertySerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 6c90124dc2247afd33c1b8994c3fdb5f85e33d2c..943df6b752848c1dff5d2d499cc7ead837300d55 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2323,6 +2323,13 @@ const CSSValue* ComputedStyleCSSValueMapping::get(

layoutObject, styledNode,

allowVisitedStyle);

}

+ case CSSPropertyPlaceItems: {

+ // TODO (jfernandez): The spec states that we should return the specified

+ // value.

+ return valuesForShorthandProperty(placeItemsShorthand(), style,

+ layoutObject, styledNode,

+ allowVisitedStyle);

+ }

case CSSPropertyAlignContent:

return valueForContentPositionAndDistributionWithOverflowAlignment(

style.alignContent(), CSSValueStretch);