Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 273783002: Simplify content_shell_resources target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, darin-cc_chromium.org, jam, chromium-apps-reviews_chromium.org, tony
Visibility:
Public.

Description

Simplify content_shell_resources target. Looks simpler that way instead of having the action that generates the pak file and the header files separated. BUG=None TEST=None R=jamescook@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M apps/shell/app_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Is this OK? (Is there a reason for the separation?)
6 years, 7 months ago (2014-05-07 21:57:18 UTC) #1
James Cook
I don't know why it was built that way, but apps/shell LGTM
6 years, 7 months ago (2014-05-07 23:44:00 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-08 07:06:37 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-11 05:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/273783002/1
6 years, 7 months ago (2014-05-11 05:21:50 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 14:22:10 UTC) #6
Message was sent while issue was closed.
Change committed as 269706

Powered by Google App Engine
This is Rietveld 408576698