chrome/typemaps.gni - Issue 2737763002: Convert utility process Safe Browsing ZIP/DMG Analyzer IPC to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/typemaps.gni

Issue 2737763002: Convert utility process Safe Browsing ZIP/DMG Analyzer IPC to mojo (Closed)

Patch Set: Minor comment fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 typemaps = [ "//chrome/common/instant.typemap" ]	5 typemaps = [

	6 "//chrome/common/safe_archive_analyzer.typemap",
	Noel Gordon 2017/03/09 08:53:21 Also, this part vexed me. Just shoved it in here Also, this part vexed me. Just shoved it in here since this .gni file existed. I noticed instant.mojo near my changes to in chrome/common/BUILD.gn, and this is where they put their typemap. Alternative would to be to add chrome/common/typemaps.gni and add put my typemap therein. Sam McNally 2017/03/09 08:58:28 There aren't any guidelines that I know of on how Show quoted text On 2017/03/09 08:53:21, noel gordon wrote: > Also, this part vexed me. Just shoved it in here since this .gni file existed. > I noticed instant.mojo near my changes to in chrome/common/BUILD.gn, and this > is where they put their typemap. > > Alternative would to be to add chrome/common/typemaps.gni and add put my typemap > therein. There aren't any guidelines that I know of on how fine-grained typemaps.gni files should be. Perhaps we could improve that.
	7 "//chrome/common/instant.typemap",

	8 ]

OLD	NEW