Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2737753002: Make parser and scanner suites able to run standalone. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose, danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make parser and scanner suites able to run standalone. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/6ac2b0ced447a1d40d6eca3b758b6b8de4b88cb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M pkg/front_end/test/fasta/parser/parser.status View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/parser/parser_suite.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/scanner/scanner_suite.dart View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
3 years, 9 months ago (2017-03-07 15:13:32 UTC) #3
danrubel
LGTM
3 years, 9 months ago (2017-03-07 17:40:55 UTC) #4
ahe
3 years, 9 months ago (2017-03-09 13:57:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
6ac2b0ced447a1d40d6eca3b758b6b8de4b88cb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698