chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc - Issue 2737563007: Add support for tracking loading behavior of child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)

Patch Set: stop observing if started in background Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

index b2e75e5652ed7eab426d08b2a3f5f4acbc685b0f..a3ff77b3499f25db36673fe1d1ea446a5e10388c 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

@@ -279,7 +279,7 @@ TEST_F(MetricsWebContentsObserverTest, NotInMainFrame) {

ASSERT_EQ(0, CountUpdatedTimingReported());

ASSERT_EQ(1, CountCompleteTimingReported());

ASSERT_EQ(1, CountEmptyCompleteTimingReported());

- CheckErrorEvent(ERR_IPC_FROM_WRONG_FRAME, 1);

+ CheckErrorEvent(ERR_TIMING_IPC_FROM_SUBFRAME, 1);

CheckErrorEvent(ERR_NO_IPCS_RECEIVED, 1);

CheckTotalErrorEvents();

}

@@ -368,7 +368,7 @@ TEST_F(MetricsWebContentsObserverTest, NotInMainError) {

subframe_tester->SimulateNavigationStart(GURL(kDefaultTestUrl2));

subframe_tester->SimulateNavigationCommit(GURL(kDefaultTestUrl2));

SimulateTimingUpdate(timing, subframe);

- CheckErrorEvent(ERR_IPC_FROM_WRONG_FRAME, 1);

+ CheckErrorEvent(ERR_TIMING_IPC_FROM_SUBFRAME, 1);

CheckTotalErrorEvents();

ASSERT_EQ(0, CountUpdatedTimingReported());

ASSERT_EQ(0, CountCompleteTimingReported());