chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc - Issue 2737563007: Add support for tracking loading behavior of child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)

Patch Set: improve test comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

index 0125164312986f7caa22b0b363d4df99441ae14e..f788e454ea10b713670bfe881796a15fa683c3ba 100644

--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

@@ -48,7 +48,7 @@ namespace {

bool IsServiceWorkerControlled(

const page_load_metrics::PageLoadExtraInfo& info) {

- return (info.metadata.behavior_flags &

+ return (info.main_frame_metadata.behavior_flags &

blink::WebLoadingBehaviorFlag::

WebLoadingBehaviorServiceWorkerControlled) != 0;

}