Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6193)

Unified Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)
Patch Set: test fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
diff --git a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
index 00187883ce76f4d7d8d33c4a1e10c8f5d5629f61..100493247ef6c9513cdfb2a0986caff0b1bd8b22 100644
--- a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
+++ b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
@@ -29,8 +29,10 @@ PageTimingMetricsSender::PageTimingMetricsSender(
timer_(std::move(timer)),
last_timing_(initial_timing),
metadata_(PageLoadMetadata()) {
- // Send an initial IPC relatively early to help track aborts.
- EnsureSendTimer(kInitialTimerDelayMillis);
+ if (!last_timing_.IsEmpty()) {
Charlie Harrison 2017/03/08 21:47:17 nit: I think using the initial_timing makes the co
Bryan McQuade 2017/03/09 03:06:12 done
+ // Send an initial IPC relatively early to help track aborts.
+ EnsureSendTimer(kInitialTimerDelayMillis);
+ }
}
// On destruction, we want to send any data we have if we have a timer

Powered by Google App Engine
This is Rietveld 408576698