chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc - Issue 2737563007: Add support for tracking loading behavior of child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)

Patch Set: test fixes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

index 32de069d547e22496ea34b0bc4a45c170dd139c8..3211a95f6fbc8ca32f474393c70efd1f8c569e29 100644

--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

@@ -189,8 +189,11 @@ void SubresourceFilterMetricsObserver::OnLoadingBehaviorObserved(

if (subresource_filter_observed_)

return;

+ const int all_frame_loading_behavior_flags =

+ info.metadata.behavior_flags | info.child_loading_behavior_flags;

subresource_filter_observed_ =

- (info.metadata.behavior_flags &

+ (all_frame_loading_behavior_flags &

blink::WebLoadingBehaviorFlag::

WebLoadingBehaviorSubresourceFilterMatch) != 0;