Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 11 matching lines...) Expand all
22 PageTimingMetricsSender::PageTimingMetricsSender( 22 PageTimingMetricsSender::PageTimingMetricsSender(
23 IPC::Sender* ipc_sender, 23 IPC::Sender* ipc_sender,
24 int routing_id, 24 int routing_id,
25 std::unique_ptr<base::Timer> timer, 25 std::unique_ptr<base::Timer> timer,
26 const PageLoadTiming& initial_timing) 26 const PageLoadTiming& initial_timing)
27 : ipc_sender_(ipc_sender), 27 : ipc_sender_(ipc_sender),
28 routing_id_(routing_id), 28 routing_id_(routing_id),
29 timer_(std::move(timer)), 29 timer_(std::move(timer)),
30 last_timing_(initial_timing), 30 last_timing_(initial_timing),
31 metadata_(PageLoadMetadata()) { 31 metadata_(PageLoadMetadata()) {
32 // Send an initial IPC relatively early to help track aborts. 32 if (!initial_timing.IsEmpty()) {
33 EnsureSendTimer(kInitialTimerDelayMillis); 33 // Send an initial IPC relatively early to help track aborts.
34 EnsureSendTimer(kInitialTimerDelayMillis);
35 }
34 } 36 }
35 37
36 // On destruction, we want to send any data we have if we have a timer 38 // On destruction, we want to send any data we have if we have a timer
37 // currently running (and thus are talking to a browser process) 39 // currently running (and thus are talking to a browser process)
38 PageTimingMetricsSender::~PageTimingMetricsSender() { 40 PageTimingMetricsSender::~PageTimingMetricsSender() {
39 if (timer_->IsRunning()) { 41 if (timer_->IsRunning()) {
40 timer_->Stop(); 42 timer_->Stop();
41 SendNow(); 43 SendNow();
42 } 44 }
43 } 45 }
(...skipping 28 matching lines...) Expand all
72 FROM_HERE, base::TimeDelta::FromMilliseconds(delay), 74 FROM_HERE, base::TimeDelta::FromMilliseconds(delay),
73 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 75 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
74 } 76 }
75 77
76 void PageTimingMetricsSender::SendNow() { 78 void PageTimingMetricsSender::SendNow() {
77 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated( 79 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
78 routing_id_, last_timing_, metadata_)); 80 routing_id_, last_timing_, metadata_));
79 } 81 }
80 82
81 } // namespace page_load_metrics 83 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698