chrome/renderer/page_load_metrics/metrics_render_frame_observer.h - Issue 2737563007: Add support for tracking loading behavior of child frames.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/page_load_metrics/page_load_metrics_observer.h ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_	5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_

6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_	6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 26 matching lines...) Expand all Loading...
37	37

38 private:	38 private:

39 // Will be null when we're not actively sending metrics.	39 // Will be null when we're not actively sending metrics.

40 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;	40 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;

41	41

42 void SendMetrics();	42 void SendMetrics();

43 virtual bool ShouldSendMetrics() const;	43 virtual bool ShouldSendMetrics() const;

44 virtual PageLoadTiming GetTiming() const;	44 virtual PageLoadTiming GetTiming() const;

45 virtual std::unique_ptr<base::Timer> CreateTimer() const;	45 virtual std::unique_ptr<base::Timer> CreateTimer() const;

46 virtual bool HasNoRenderFrame() const;	46 virtual bool HasNoRenderFrame() const;

	47 virtual bool IsMainFrame() const;

47	48

48 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);	49 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);

49 };	50 };

50	51

51 } // namespace page_load_metrics	52 } // namespace page_load_metrics

52	53

53 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_	54 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_

OLD	NEW