Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ | 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ |
| 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ | 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ |
| 7 | 7 |
| 8 #include <memory> | 8 #include <memory> |
| 9 | 9 |
| 10 #include "base/macros.h" | 10 #include "base/macros.h" |
| 11 #include "chrome/common/page_load_metrics/page_load_timing.h" | 11 #include "chrome/common/page_load_metrics/page_load_timing.h" |
| 12 #include "content/public/renderer/render_frame_observer.h" | 12 #include "content/public/renderer/render_frame_observer.h" |
| 13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" | 13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" |
| 14 | 14 |
| 15 namespace base { | 15 namespace base { |
| 16 class Timer; | 16 class Timer; |
| 17 } // namespace base | 17 } // namespace base |
| 18 | 18 |
| 19 namespace page_load_metrics { | 19 namespace page_load_metrics { |
| 20 | 20 |
| 21 class PageTimingMetricsSender; | 21 class PageTimingMetricsSender; |
| 22 | 22 |
| 23 // MetricsRenderFrameObserver observes RenderFrame notifications, and | 23 // MetricsRenderFrameObserver observes RenderFrame notifications, and |
| 24 // sends page load timing information to the browser process over IPC. | 24 // sends page load timing information to the browser process over IPC. |
|
Charlie Harrison
2017/03/08 21:47:17
Can you please update the class comments for this
Bryan McQuade
2017/03/09 03:06:11
Good idea, done.
| |
| 25 class MetricsRenderFrameObserver : public content::RenderFrameObserver { | 25 class MetricsRenderFrameObserver : public content::RenderFrameObserver { |
| 26 public: | 26 public: |
| 27 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); | 27 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); |
| 28 ~MetricsRenderFrameObserver() override; | 28 ~MetricsRenderFrameObserver() override; |
| 29 | 29 |
| 30 // RenderFrameObserver implementation | 30 // RenderFrameObserver implementation |
| 31 void DidChangePerformanceTiming() override; | 31 void DidChangePerformanceTiming() override; |
| 32 void DidObserveLoadingBehavior( | 32 void DidObserveLoadingBehavior( |
| 33 blink::WebLoadingBehaviorFlag behavior) override; | 33 blink::WebLoadingBehaviorFlag behavior) override; |
| 34 void DidCommitProvisionalLoad(bool is_new_navigation, | 34 void DidCommitProvisionalLoad(bool is_new_navigation, |
| 35 bool is_same_page_navigation) override; | 35 bool is_same_page_navigation) override; |
| 36 void OnDestruct() override; | 36 void OnDestruct() override; |
| 37 | 37 |
| 38 private: | 38 private: |
| 39 // Will be null when we're not actively sending metrics. | 39 // Will be null when we're not actively sending metrics. |
| 40 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; | 40 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; |
| 41 | 41 |
| 42 void SendMetrics(); | 42 void SendMetrics(); |
| 43 virtual bool ShouldSendMetrics() const; | 43 virtual bool ShouldSendMetrics() const; |
| 44 virtual PageLoadTiming GetTiming() const; | 44 virtual PageLoadTiming GetTiming() const; |
| 45 virtual std::unique_ptr<base::Timer> CreateTimer() const; | 45 virtual std::unique_ptr<base::Timer> CreateTimer() const; |
| 46 virtual bool HasNoRenderFrame() const; | 46 virtual bool HasNoRenderFrame() const; |
| 47 virtual bool IsMainFrame() const; | |
| 47 | 48 |
| 48 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); | 49 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); |
| 49 }; | 50 }; |
| 50 | 51 |
| 51 } // namespace page_load_metrics | 52 } // namespace page_load_metrics |
| 52 | 53 |
| 53 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ | 54 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ |
| OLD | NEW |