Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ios/clean/chrome/browser/browser_coordinator.mm

Issue 2737563006: [ios] Adds support for Find in Page to the new architecture. (Closed)
Patch Set: Partially hook up the text field Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/browser_coordinator.mm
diff --git a/ios/clean/chrome/browser/browser_coordinator.mm b/ios/clean/chrome/browser/browser_coordinator.mm
index 828ae8d4f6c66cd4e69feb3565c4e17be8c95f16..baf124e91973d53bea63c6869f6c69ff8bf46332 100644
--- a/ios/clean/chrome/browser/browser_coordinator.mm
+++ b/ios/clean/chrome/browser/browser_coordinator.mm
@@ -68,6 +68,7 @@
coordinator.parentCoordinator = self;
coordinator.browser = self.browser;
coordinator.context.baseViewController = self.viewController;
+ [coordinator coordinatorDidMoveToParent:self];
rohitrao (ping after 24h) 2017/03/14 01:10:36 1) I found a need for a "didMoveToParent" method.
}
- (BrowserCoordinator*)overlayCoordinator {
@@ -122,6 +123,10 @@
coordinator.parentCoordinator = nil;
}
+- (void)coordinatorDidMoveToParent:(BrowserCoordinator*)parentCoordinator {
+ // Default implementation is a no-op.
+}
+
- (void)childCoordinatorDidStart:(BrowserCoordinator*)childCoordinator {
// Default implementation is a no-op.
}

Powered by Google App Engine
This is Rietveld 408576698