Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm

Issue 2737563006: [ios] Adds support for Find in Page to the new architecture. (Closed)
Patch Set: ObjC mediator Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
index 1b47378c74c7c8e1030f54da492f96940d6756d7..4f918f73de0531be176543a9fd4c0a58f4b34d13 100644
--- a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
@@ -8,9 +8,11 @@
#import "base/logging.h"
#import "base/macros.h"
#import "ios/chrome/browser/ui/rtl_geometry.h"
+#import "ios/clean/chrome/browser/ui/commands/find_in_page_visibility_commands.h"
#import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"
#import "ios/clean/chrome/browser/ui/toolbar/toolbar_button.h"
#import "ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h"
+#import "ios/clean/chrome/browser/ui/tools/tools_actions.h"
#import "ios/clean/chrome/browser/ui/tools/tools_menu_item.h"
#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
@@ -23,16 +25,16 @@ const CGFloat kMenuWidth = 250;
const CGFloat kMenuItemHeight = 48;
}
-@interface MenuViewController ()
+@interface MenuViewController ()<ToolsActions>
@property(nonatomic, strong) NSArray<ToolsMenuItem*>* menuItems;
@property(nonatomic, strong)
MenuOverflowControlsStackView* toolbarOverflowStackView;
@end
@implementation MenuViewController
+@synthesize dispatcher = _dispatcher;
@synthesize menuItems = _menuItems;
@synthesize toolbarOverflowStackView = _toolbarOverflowStackView;
-@synthesize dispatcher = _dispatcher;
- (void)loadView {
CGRect frame;
@@ -61,7 +63,8 @@ const CGFloat kMenuItemHeight = 48;
action:@selector(closeToolsMenu:)
forControlEvents:UIControlEventTouchUpInside];
if (item.action) {
- [menuButton addTarget:nil
+ id target = (item.action == @selector(showFindInPage)) ? self : nil;
+ [menuButton addTarget:target
action:item.action
forControlEvents:UIControlEventTouchUpInside];
}
@@ -110,6 +113,10 @@ const CGFloat kMenuItemHeight = 48;
[self.dispatcher closeToolsMenu];
}
+- (void)showFindInPage {
+ [self.dispatcher showFindInPage];
+}
+
#pragma mark - Tools Consumer
- (void)setToolsMenuItems:(NSArray*)menuItems {

Powered by Google App Engine
This is Rietveld 408576698