ios/clean/chrome/browser/ui/tools/menu_view_controller.h - Issue 2737563006: [ios] Adds support for Find in Page to the new architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/tools/menu_view_controller.h

Issue 2737563006: [ios] Adds support for Find in Page to the new architecture. (Closed)

Patch Set: Partially hook up the text field Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/tab/tab_coordinator.mm ('K') | « ios/clean/chrome/browser/ui/tools/BUILD.gn ('k') | ios/clean/chrome/browser/ui/tools/menu_view_controller.mm » ('j') | ios/clean/chrome/browser/ui/tools/menu_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // ====== New Architecture =====	5 // ====== New Architecture =====

6 // = This code is only used in the new iOS Chrome architecture. =	6 // = This code is only used in the new iOS Chrome architecture. =

7 // ============================================================================	7 // ============================================================================

8	8

9 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_VIEW_CONTROLLER_H_	9 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_VIEW_CONTROLLER_H_

10 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_VIEW_CONTROLLER_H_	10 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_VIEW_CONTROLLER_H_

11	11

12 #import <UIKit/UIKit.h>	12 #import <UIKit/UIKit.h>

13	13

	14 #import "ios/clean/chrome/browser/ui/commands/find_in_page_commands.h"
	lpromero 2017/03/14 17:17:57 Can be forward declared. Can be forward declared.
	15

14 // View controller that displays a vertical list of buttons to act as a menu.	16 // View controller that displays a vertical list of buttons to act as a menu.

15 // The view controller dismisses as soon as any of the buttons, or any area	17 // The view controller dismisses as soon as any of the buttons, or any area

16 // outside the presentation area, is tapped.	18 // outside the presentation area, is tapped.

17 @interface MenuViewController : UIViewController	19 @interface MenuViewController : UIViewController

	20

	21 @property(nonatomic, readwrite, weak) id<FindInPageCommands> dispatcher;
	lpromero 2017/03/14 17:17:57 No need for readwrite. No need for readwrite.
	22

18 @end	23 @end

19	24

20 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_VIEW_CONTROLLER_H_	25 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_VIEW_CONTROLLER_H_

OLD	NEW