ios/clean/chrome/browser/ui/find_in_page/BUILD.gn - Issue 2737563006: [ios] Adds support for Find in Page to the new architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/find_in_page/BUILD.gn

Issue 2737563006: [ios] Adds support for Find in Page to the new architecture. (Closed)

Patch Set: Partially hook up the text field Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/commands/find_in_page_commands.h ('K') | « ios/clean/chrome/browser/ui/commands/find_in_page_commands.h ('k') | ios/clean/chrome/browser/ui/find_in_page/find_in_page_consumer.h » ('j') | ios/clean/chrome/browser/ui/find_in_page/find_in_page_consumer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("find_in_page") {

	6 sources = [

	7 "find_in_page_coordinator.h",

	8 "find_in_page_coordinator.mm",

	9 "find_in_page_mediator.h",

	10 "find_in_page_mediator.mm",

	11 ]

	12

	13 configs += [ "//build/config/compiler:enable_arc" ]

	14

	15 deps = [

	16 ":find_in_page_ui",

	17 "//base",

	18 "//ios/chrome/browser/find_in_page",

	19 "//ios/clean/chrome/browser",

	20 "//ios/clean/chrome/browser/model",

	21 "//ios/clean/chrome/browser/ui/actions",

	22 "//ios/clean/chrome/browser/ui/animators",

	23 "//ios/clean/chrome/browser/ui/commands",

	24 "//ios/shared/chrome/browser/coordinator_context",

	25 "//ios/shared/chrome/browser/tabs",

	26 "//ios/web",

	27 ]

	28 }

	29

	30 source_set("find_in_page_ui") {
	lpromero 2017/03/14 17:17:56 Can you follow up and integrate this in Showcase? Can you follow up and integrate this in Showcase?
	31 sources = [

	32 "find_in_page_consumer.h",

	33 "find_in_page_view_controller.h",

	34 "find_in_page_view_controller.mm",

	35 ]

	36 deps = [

	37 "//base",

	38 "//components/strings",

	39 "//ios/chrome/browser/ui/find_bar",

	40 "//ios/clean/chrome/browser/ui",

	41 "//ios/clean/chrome/browser/ui/actions",

	42 "//ios/clean/chrome/browser/ui/animators",

	43 "//ios/clean/chrome/browser/ui/commands",

	44 "//ios/clean/chrome/browser/ui/presenters",

	45 "//ui/base",

	46 ]

	47 libs = [ "UIKit.framework" ]

	48 configs += [ "//build/config/compiler:enable_arc" ]

	49 }

OLD	NEW