ios/clean/chrome/browser/ui/commands/find_in_page_search_commands.h - Issue 2737563006: [ios] Adds support for Find in Page to the new architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/find_in_page_search_commands.h

Issue 2737563006: [ios] Adds support for Find in Page to the new architecture. (Closed)

Patch Set: ObjC mediator Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/commands/BUILD.gn ('k') | ios/clean/chrome/browser/ui/commands/find_in_page_visibility_commands.h » ('j') | ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_FIND_IN_PAGE_SEARCH_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_FIND_IN_PAGE_SEARCH_COMMANDS_H_

	7

	8 // Command protocol for commands relating to Find In Page.

	9 @protocol FindInPageSearchCommands

	10

	11 // Searches for the given string in the current page.

	12 - (void)findStringInPage:(NSString*)searchTerm;

	13

	14 // Finds the previous and next matches, using the current search string.
	marq (ping after 24h) 2017/04/06 16:13:27 If -findStringInPage: hasn't been called, what is If -findStringInPage: hasn't been called, what is an adopter of this protocol expected to do when either of these methods is called? rohitrao (ping after 24h) 2017/04/06 16:27:07 Will figure this out and update the comment. (In Show quoted text On 2017/04/06 16:13:27, marq wrote: > If -findStringInPage: hasn't been called, what is an adopter of this protocol > expected to do when either of these methods is called? Will figure this out and update the comment. (In practice, it will probably open the find bar and "search" for the empty string.) rohitrao (ping after 24h) 2017/04/11 20:46:16 Done. Show quoted text On 2017/04/06 16:27:07, rohitrao wrote: > On 2017/04/06 16:13:27, marq wrote: > > If -findStringInPage: hasn't been called, what is an adopter of this protocol > > expected to do when either of these methods is called? > > Will figure this out and update the comment. (In practice, it will probably > open the find bar and "search" for the empty string.) Done.
	15 - (void)findNextInPage;

	16 - (void)findPreviousInPage;

	17

	18 @end

	19

	20 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_FIND_IN_PAGE_SEARCH_COMMANDS_H_

OLD	NEW