third_party/WebKit/Source/bindings/core/v8/WindowProxy.h - Issue 2737553007: Duplicate WindowProxy::disposeContext() into subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

Issue 2737553007: Duplicate WindowProxy::disposeContext() into subclasses. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

index 6276d715cb0c6e4db86aaa4e844852c5629b8402..393faea76c3a4d5293f46bec88833fe44eb5373a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

@@ -162,7 +162,7 @@ class WindowProxy : public GarbageCollectedFinalized<WindowProxy> {

virtual void initialize() = 0;

enum GlobalDetachmentBehavior { DoNotDetachGlobal, DetachGlobal };

- virtual void disposeContext(GlobalDetachmentBehavior);

+ virtual void disposeContext(GlobalDetachmentBehavior) = 0;

v8::Isolate* isolate() const { return m_isolate; }

Frame* frame() const { return m_frame.get(); }