Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7452)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2737553004: Set background color when adding a new tab. (Closed)
Patch Set: none Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index d2063c2f561ca8edecea3ef93c812f62903d6b41..d83e4e7c4d83cec4710de4cc508dddfc4ac282bc 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1040,6 +1040,22 @@ void Browser::ActiveTabChanged(WebContents* old_contents,
WebContents* new_contents,
int index,
int reason) {
+ // Copies the background color from an old WebContents to a new one that
+ // replaces it on the screen. This allows the new WebContents to use the
+ // old one's background color as the starting background color, before having
+ // loaded any contents. As a result, we avoid flashing white when moving to
+ // a new tab. (There is also code in RenderFrameHostManager to do something
+ // similar for intra-tab navigations.)
+ if (old_contents && new_contents) {
+ // While GetMainFrame() is guaranteed to return non-null, GetView() is not,
+ // e.g. between WebContents creation and creation of the
+ // RenderWidgetHostView.
+ RenderWidgetHostView* old_view = old_contents->GetMainFrame()->GetView();
+ RenderWidgetHostView* new_view = new_contents->GetMainFrame()->GetView();
+ if (old_view && new_view)
+ new_view->SetBackgroundColor(old_view->background_color());
+ }
+
content::RecordAction(UserMetricsAction("ActiveTabChanged"));
// Update the bookmark state, since the BrowserWindow may query it during
« no previous file with comments | « no previous file | chrome/browser/ui/browser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698