Set background color when adding a new tab.

chrome/browser/ui/browser_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #include "base/macros.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/browser_command_controller.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/browser_with_test_window_test.h"
 #include "components/zoom/zoom_controller.h"
+#include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/web_contents_tester.h"
+#include "third_party/skia/include/core/SkColor.h"
 
 using content::SiteInstance;
 using content::WebContents;
 using content::WebContentsTester;
 
 class BrowserUnitTest : public BrowserWithTestWindowTest {
  public:
   BrowserUnitTest() {}
   ~BrowserUnitTest() override {}
 
@@ skipping 32 matching lines @@
   contents2->SetIsCrashed(base::TERMINATION_STATUS_PROCESS_CRASHED, -1);
   EXPECT_TRUE(contents2->IsCrashed());
 
   // Selecting the second tab does not cause a load or clear the crash.
   tab_strip_model->ActivateTabAt(1, true);
   EXPECT_TRUE(tab_strip_model->IsTabSelected(1));
   EXPECT_FALSE(contents2->IsLoading());
   EXPECT_TRUE(contents2->IsCrashed());
 }
 
+TEST_F(BrowserUnitTest, SetBackgroundColorForNewTab) {
+  TabStripModel* tab_strip_model = browser()->tab_strip_model();
+
+  WebContents* contents1 = CreateTestWebContents();
+  tab_strip_model->AppendWebContents(contents1, true);
+  WebContentsTester::For(contents1)->NavigateAndCommit(GURL("about:blank"));
+  WebContentsTester::For(contents1)->TestSetIsLoading(false);
+
+  contents1->GetMainFrame()->GetView()->SetBackgroundColor(SK_ColorRED);
+
+  // Add a second tab in the background.
+  WebContents* contents2 = CreateTestWebContents();
+  tab_strip_model->AppendWebContents(contents2, false);
+  WebContentsTester::For(contents2)->NavigateAndCommit(GURL("about:blank"));
+  WebContentsTester::For(contents2)->TestSetIsLoading(false);
+
+  // Color is only set once the tab is activated.

[Peter Kasting, 2017/03/07 00:28:36]

Why is it important to test this?  It doesn't seem like it would be a bug if we
violated this in the future.

[chrishtr, 2017/03/07 00:36:48]

Fair point. Deleted this part.

+  EXPECT_FALSE(SK_ColorRED ==
+               contents2->GetMainFrame()->GetView()->background_color());
+
+  tab_strip_model->ActivateTabAt(1, true);
+  EXPECT_EQ(SK_ColorRED,
+            contents2->GetMainFrame()->GetView()->background_color());
+}
+
 // Ensure the print command gets disabled when a tab crashes.
 TEST_F(BrowserUnitTest, DisablePrintOnCrashedTab) {
   TabStripModel* tab_strip_model = browser()->tab_strip_model();
 
   WebContents* contents = CreateTestWebContents();
   tab_strip_model->AppendWebContents(contents, true);
   WebContentsTester::For(contents)->NavigateAndCommit(GURL("about:blank"));
 
   CommandUpdater* command_updater =
       browser()->command_controller()->command_updater();
@@ skipping 139 matching lines @@
   // Activate the 1st tab which is NTP.
   browser()->tab_strip_model()->ActivateTabAt(0, true);
   EXPECT_EQ(BookmarkBar::SHOW, browser()->bookmark_bar_state());
   EXPECT_EQ(BookmarkBar::SHOW, window_bookmark_bar_state());
 
   // Activate the 2nd tab which is non-NTP.
   browser()->tab_strip_model()->ActivateTabAt(1, true);
   EXPECT_EQ(BookmarkBar::SHOW, browser()->bookmark_bar_state());
   EXPECT_EQ(BookmarkBar::SHOW, window_bookmark_bar_state());
 }