Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1736)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2737553003: Remove ChildProcess.HangRendererType. (Closed)
Patch Set: rebase on new version Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index f43db083dedbfd5c9c1dc9fb3f09d05cbc5e5c0a..91cf8994d4116fc2013ecfd0102fa21358a2d261 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2548,8 +2548,6 @@ void RenderFrameHostImpl::DispatchBeforeUnload(bool for_navigation,
// reply from the dialog.
SimulateBeforeUnloadAck();
} else {
- beforeunload_timeout_type_ =
- RendererUnresponsiveType::RENDERER_UNRESPONSIVE_BEFORE_UNLOAD;
beforeunload_timeout_->Start(
TimeDelta::FromMilliseconds(RenderViewHostImpl::kUnloadTimeoutMS));
send_before_unload_start_time_ = base::TimeTicks::Now();
@@ -2631,17 +2629,8 @@ void RenderFrameHostImpl::JavaScriptDialogClosed(
// presumably malicious, so there's no point in continuing to run its
// script and dragging out the process.
if (dialog_was_suppressed) {
- UMA_HISTOGRAM_ENUMERATION(
- "ChildProcess.HangRendererType",
- RendererUnresponsiveType::RENDERER_UNRESPONSIVE_DIALOG_SUPPRESSED,
- RendererUnresponsiveType::RENDERER_UNRESPONSIVE_MAX);
-
frame->SimulateBeforeUnloadAck();
} else {
- frame->beforeunload_timeout_type_ =
- success
- ? RendererUnresponsiveType::RENDERER_UNRESPONSIVE_BEFORE_UNLOAD
- : RendererUnresponsiveType::RENDERER_UNRESPONSIVE_DIALOG_CLOSED;
frame->beforeunload_timeout_->Start(
TimeDelta::FromMilliseconds(RenderViewHostImpl::kUnloadTimeoutMS));
}
@@ -3476,10 +3465,6 @@ void RenderFrameHostImpl::BeforeUnloadTimeout() {
if (render_view_host_->GetDelegate()->ShouldIgnoreUnresponsiveRenderer())
return;
- UMA_HISTOGRAM_ENUMERATION(
- "ChildProcess.HangRendererType", beforeunload_timeout_type_,
- RendererUnresponsiveType::RENDERER_UNRESPONSIVE_MAX);
-
SimulateBeforeUnloadAck();
}

Powered by Google App Engine
This is Rietveld 408576698