Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: chrome/browser/engagement/site_engagement_score.h

Issue 2737533003: Grant bonus engagement to origins with notification permission. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_score.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_score.h
diff --git a/chrome/browser/engagement/site_engagement_score.h b/chrome/browser/engagement/site_engagement_score.h
index bb29a78d6059174828f1f06cdf107be280d9b3d2..861799a737ffc5df34fe992ad6f9753c75fb2f7a 100644
--- a/chrome/browser/engagement/site_engagement_score.h
+++ b/chrome/browser/engagement/site_engagement_score.h
@@ -84,6 +84,9 @@ class SiteEngagementScore {
// period prior to clock_->Now().
LAST_ENGAGEMENT_GRACE_PERIOD_IN_HOURS,
+ // THe number of points given for having notification permission granted.
+ NOTIFICATION_PERMISSION_POINTS,
+
MAX_VARIATION
};
@@ -106,6 +109,7 @@ class SiteEngagementScore {
static double GetHighEngagementBoundary();
static double GetMaxDecaysPerScore();
static double GetLastEngagementGracePeriodInHours();
+ static double GetNotificationPermissionPoints();
// Update the default engagement settings via variations.
static void UpdateFromVariations(const char* param_name);
@@ -164,6 +168,7 @@ class SiteEngagementScore {
friend class ChromePluginServiceFilterTest;
friend class ImportantSitesUtil;
friend class ImportantSitesUtilTest;
+ friend class PushMessagingBrowserTest;
friend class SiteEngagementHelperTest;
friend class SiteEngagementScoreTest;
friend class SiteEngagementServiceTest;
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_score.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698