Issue 273753005: Revert of Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273753005: Revert of Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded. (Closed)

Created:
6 years, 7 months ago by Nikita (slow)

Modified:
6 years, 7 months ago

Reviewers:
Nicolas Zea, jianli, juyik

CC:
chromium-reviews, fgorski

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded. (https://codereview.chromium.org/266913015/) Reason for revert: Introduces crash on sign in on Chrome OS. BUG=371297 https://code.google.com/p/chromium/issues/detail?id=371297 Original issue's description: > Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded. > > BUG=341256 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268976 TBR=jianli@chromium.org,zea@chromium.org,juyik@chromium.org NOTREECHECKS=true NOTRY=true BUG=341256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269053

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -61 lines)			Patch
M	chrome/browser/services/gcm/gcm_service.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	google_apis/gcm/gcm_client.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	google_apis/gcm/gcm_client_impl.h	View	4 chunks	+3 lines, -5 lines	0 comments	Download
M	google_apis/gcm/gcm_client_impl.cc	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	google_apis/gcm/gcm_client_impl_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	google_apis/gcm/monitoring/gcm_stats_recorder.h	View	4 chunks	+0 lines, -21 lines	0 comments	Download
M	google_apis/gcm/monitoring/gcm_stats_recorder.cc	View	8 chunks	+1 line, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

Nikita (slow)

Created Revert of Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded.

6 years, 7 months ago (2014-05-08 12:17:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/273753005/1

6 years, 7 months ago (2014-05-08 12:21:14 UTC) #3

Message was sent while issue was closed.

Change committed as 269053