Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: media/mojo/services/BUILD.gn

Issue 2737513004: Fix media_mojo builds (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/mojo/BUILD.gn ('K') | « media/mojo/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/BUILD.gn
diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn
index 432130d01c557fa2c89f4901d53077f54c5eabea..3eccceb652e5eb9aa735d5dca26b43407eec2f84 100644
--- a/media/mojo/services/BUILD.gn
+++ b/media/mojo/services/BUILD.gn
@@ -138,10 +138,10 @@ source_set("lib") {
service("media") {
testonly = true
- # crbug.com/676418: Suppress symbol import warnings.
- if (is_win && is_component_build) {
- ldflags = [ "/ignore:4217" ]
- }
+ # As long as //media/mojo/services:lib is a source_set, this needs to be
+ # set as the source will be bundled with this service code.
xhwang 2017/03/08 00:35:18 Could you please provide a few more details, e.g.
+ # http://crbug.com/670094
+ defines = [ "MEDIA_MOJO_IMPLEMENTATION" ]
sources = [
"main.cc",
« media/mojo/BUILD.gn ('K') | « media/mojo/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698