Chromium Code Reviews| Index: media/mojo/services/BUILD.gn |
| diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn |
| index 432130d01c557fa2c89f4901d53077f54c5eabea..3eccceb652e5eb9aa735d5dca26b43407eec2f84 100644 |
| --- a/media/mojo/services/BUILD.gn |
| +++ b/media/mojo/services/BUILD.gn |
| @@ -138,10 +138,10 @@ source_set("lib") { |
| service("media") { |
| testonly = true |
| - # crbug.com/676418: Suppress symbol import warnings. |
| - if (is_win && is_component_build) { |
| - ldflags = [ "/ignore:4217" ] |
| - } |
| + # As long as //media/mojo/services:lib is a source_set, this needs to be |
| + # set as the source will be bundled with this service code. |
|
xhwang
2017/03/08 00:35:18
Could you please provide a few more details, e.g.
|
| + # http://crbug.com/670094 |
| + defines = [ "MEDIA_MOJO_IMPLEMENTATION" ] |
| sources = [ |
| "main.cc", |