Fix media_mojo builds

media/mojo/services/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//media/media_options.gni")
 import("//services/catalog/public/tools/catalog.gni")
 import("//services/service_manager/public/cpp/service.gni")
 import("//services/service_manager/public/service_manifest.gni")
 import("//services/service_manager/public/tools/test/service_test.gni")
 import("//testing/test.gni")
 
 component("services") {
   output_name = "media_mojo_services"
-
-  public_deps = [
-    ":lib",
-  ]
-}
-
-# TODO(xhwang): Add this intermediate target because ServiceTest doesn't support
-# services that depend on shared libraries in component build.
-# See http://crbug.com/670094
-source_set("lib") {
   sources = [
     "gpu_mojo_media_client.cc",
     "gpu_mojo_media_client.h",
     "interface_factory_impl.cc",
     "interface_factory_impl.h",
     "media_interface_provider.cc",
     "media_interface_provider.h",
     "media_mojo_export.h",
     "media_resource_shim.cc",
     "media_resource_shim.h",
@@ skipping 65 matching lines @@
       "android_mojo_media_client.h",
       "mojo_media_drm_storage.cc",
       "mojo_media_drm_storage.h",
     ]
   }
 }
 
 service("media") {
   testonly = true
 
-  # crbug.com/676418: Suppress symbol import warnings.
-  if (is_win && is_component_build) {
-    ldflags = [ "/ignore:4217" ]
-  }
-
   sources = [
     "main.cc",
   ]
 
   public_deps = [
     "//base",
     "//media",
   ]
 
   deps = [
-    ":lib",
+    ":services",
     "//mojo/public/c/system",
     "//services/service_manager/public/cpp",
   ]
 }
 
-# crbug.com/676055: media_service_unittests currently fails to link in Windows
-# component builds, so don't declare it, otherwise the "all" target will still
-# try to build it.
-if (!(is_win && is_component_build)) {
-  service_test("media_service_unittests") {
-    testonly = true
+service_test("media_service_unittests") {
+  testonly = true
 
-    sources = [
-      "media_service_unittest.cc",
-    ]
+  sources = [
+    "media_service_unittest.cc",
+  ]
 
-    catalog = ":media_service_unittests_catalog"
+  catalog = ":media_service_unittests_catalog"
 
-    deps = [
-      ":lib",
-      "//base",
-      "//media",
-      "//media/base:test_support",
-      "//media/mojo/clients",
-      "//media/mojo/common",
-      "//media/mojo/interfaces",
-      "//media/mojo/interfaces:constants",
-      "//services/service_manager/public/cpp:service_test_support",
-      "//testing/gmock",
-      "//testing/gtest",
-    ]
+  deps = [
+    ":services",
+    "//base",
+    "//media",
+    "//media/base:test_support",
+    "//media/mojo/clients",
+    "//media/mojo/common",
+    "//media/mojo/interfaces",
+    "//media/mojo/interfaces:constants",
+    "//services/service_manager/public/cpp:service_test_support",
+    "//testing/gmock",
+    "//testing/gtest",
+  ]
 
-    data_deps = [
-      ":media",
-    ]
-  }
-}  # !(is_win && is_component_build)
+  data_deps = [
+    ":media",
+  ]
+}
 
 service_manifest("media_manifest") {
   name = "media"
   source = "media_manifest.json"
 }
 
 service_manifest("test_manifest") {
   name = "media_service_unittests"
   source = "test_manifest.json"
 }
@@ skipping 19 matching lines @@
 
 catalog("media_service_unittests_catalog") {
   embedded_services = [ ":test_manifest" ]
   standalone_services = [ ":media_manifest" ]
 }
 
 catalog("media_pipeline_integration_unittests_catalog") {
   embedded_services = [ ":pipeline_test_manifest" ]
   standalone_services = [ ":media_manifest" ]
 }