Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2737453003: Fix ArcSessionManager state machine, part 1. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
index 4b5b8ad57c4bcaf22bf4a3a0803c5992c3274ae2..528d8839f32f0d2b4c203255bfa77baba13c77b8 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
@@ -3650,12 +3650,12 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcManaged) {
"AppList, Chrome, Play Store");
// ARC is managed and enabled, Play Store pin should be available.
- // Note: SHOWING_TERMS_OF_SERVICE here means that opt-in flow starts.
+ // Note: NEGOTIATING_TERMS_OF_SERVICE here means that opt-in flow starts.
profile()->GetTestingPrefService()->SetManagedPref(prefs::kArcEnabled,
new base::Value(true));
base::RunLoop().RunUntilIdle();
ValidateArcState(true, true,
- arc::ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
+ arc::ArcSessionManager::State::NEGOTIATING_TERMS_OF_SERVICE,
"AppList, Chrome, Play Store");
// ARC is managed and disabled, Play Store pin should not be available.
@@ -3674,7 +3674,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcManaged) {
// ARC is not managed and enabled, Play Store pin should be available.
EnableArc(true);
ValidateArcState(true, false,
- arc::ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
+ arc::ArcSessionManager::State::NEGOTIATING_TERMS_OF_SERVICE,
"AppList, Chrome, Play Store");
// User disables ARC. ARC is not managed and disabled, Play Store pin should
@@ -3686,7 +3686,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcManaged) {
// Even if re-enable it again, Play Store pin does not appear automatically.
EnableArc(true);
ValidateArcState(true, false,
- arc::ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
+ arc::ArcSessionManager::State::NEGOTIATING_TERMS_OF_SERVICE,
"AppList, Chrome");
}

Powered by Google App Engine
This is Rietveld 408576698