ios/web/web_state/web_state_impl.h - Issue 2737353006: Replaced webPageOrderedClose with WebStateDelegate API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_state_impl.h

Issue 2737353006: Replaced webPageOrderedClose with WebStateDelegate API. (Closed)

Patch Set: Addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/web_state_impl.h

diff --git a/ios/web/web_state/web_state_impl.h b/ios/web/web_state/web_state_impl.h

index c873eea5b6f3f9138ad13d69d46361b28c8ea151..cd496fb09baa34bb93eadc6dc68bb996727f6ed2 100644

--- a/ios/web/web_state/web_state_impl.h

+++ b/ios/web/web_state/web_state_impl.h

@@ -261,6 +261,10 @@ class WebStateImpl : public WebState, public NavigationManagerDelegate {

const GURL& opener_url,

bool initiated_by_user);

+ // Instructs the delegate to close this web state. Called when the page calls

+ // wants to close self by calling window.close() JavaScript API.

+ virtual void CloseWebState();

// Notifies the delegate that request receives an authentication challenge

// and is unable to respond using cached credentials.

void OnAuthRequired(NSURLProtectionSpace* protection_space,