Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2737353006: Replaced webPageOrderedClose with WebStateDelegate API. (Closed)
Patch Set: Addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 3cc148703393893d6f5d25800de0f097af719e06..81dd6e629220c078b2e7d23b102f4c48005a254e 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -3160,7 +3160,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
// load operation (e.g. notifying all observers) and record the URL so
// that errors reported following the 'NO' reply can be safely ignored.
if ([self shouldClosePageOnNativeApplicationLoad])
- [_delegate webPageOrderedClose];
+ _webStateImpl->CloseWebState();
[self stopLoading];
[_openedApplicationURL addObject:request.URL];
return NO;
@@ -3211,7 +3211,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
// safely ignored.
[_openedApplicationURL addObject:request.URL];
if ([self shouldClosePageOnNativeApplicationLoad])
- [_delegate webPageOrderedClose];
+ _webStateImpl->CloseWebState();
}
return NO;
}
@@ -4379,7 +4379,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
- (void)webViewDidClose:(WKWebView*)webView {
if (self.sessionController.openedByDOM) {
- [self.delegate webPageOrderedClose];
+ _webStateImpl->CloseWebState();
}
}
« no previous file with comments | « ios/web/public/web_state/web_state_delegate_bridge.h ('k') | ios/web/web_state/ui/crw_web_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698