Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: device/bluetooth/README.md

Issue 2737343003: bluetooth: Add FakeBluetooth interface (Closed)
Patch Set: Add all the READMEs! Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/README.md
diff --git a/device/bluetooth/README.md b/device/bluetooth/README.md
index f3c0ed8939fe811a3fa248b596cae8c584f85e38..1e7690fa51afb87600a8066e3b1a23f2b4bf1c09 100644
--- a/device/bluetooth/README.md
+++ b/device/bluetooth/README.md
@@ -43,93 +43,8 @@ Active development in 2015 & 2016 is focused on enabling GATT features for:
Known future work is tracked in the
[Refactoring meta issue](https://crbug.com/580406).
-
## Testing
-
-Implementation of the Bluetooth component is tested via unittests. Client code
-uses Mock Bluetooth objects:
-
-
-### Cross Platform Unit Tests
-
-New feature development uses cross platform unit tests. This reduces test code
-redundancy and produces consistency across all implementations.
-
-Unit tests operate at the public `device/bluetooth` API layer and the
-`BluetoothTest` fixture controls fake operating system behavior as close to the
-platfom as possible. The resulting test coverage spans the cross platform API,
-common implementation, and platform specific implementation as close to
-operating system APIs as possible.
-
-`test/bluetooth_test.h` defines the cross platform test fixture
-`BluetoothTestBase`. Platform implementations provide subclasses, such as
-`test/bluetooth_test_android.h` and typedef to the name `BluetoothTest`.
-
-[More testing information](https://docs.google.com/document/d/1mBipxn1sJu6jMqP0RQZpkYXC1o601bzLCpCxwTA2yGA/edit?usp=sharing)
-
-### Legacy Platform Specific Unit Tests
-
-Early code (Classic on most platforms, and Low Energy on BlueZ) was tested with
-platform specific unit tests, e.g. `bluetooth_bluez_unittest.cc` &
-`bluetooth_adapter_win_unittest.cc`. The BlueZ style has platform specific
-methods to create fake devices and the public API is used to interact with them.
-
-Maintenance of these earlier implementation featuress should update tests in
-place. Long term these tests should be [refactored into cross platform
-tests](https://crbug.com/580403).
-
-
-### Mock Bluetooth Objects
-
-`test/mock_bluetooth_*` files provide GoogleMock based fake objects for use in
-client code.
-
-
-### Chrome OS Blueooth Controller Tests
-
-Bluetooth controller system tests generating radio signals are run and managed
-by the Chrome OS team. See:
-https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/server/site_tests/
-https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/server/cros/bluetooth/
-https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/cros/bluetooth/
-
-
-## Android
-
-The android implementation requires crossing from C++ to Java using
-[__JNI__](https://www.chromium.org/developers/design-documents/android-jni).
-
-Object ownership is rooted in the C++ classes, starting with the Adapter, which
-owns Devices, Services, etc. Java counter parts interface with the Android
-Bluetooth objects. E.g.
-
-For testing, the Android objects are __wrapped__ in:
-`android/java/src/org/chromium/device/bluetooth/Wrappers.java`. <br>
-and __fakes__ implemented in:
-`test/android/java/src/org/chromium/device/bluetooth/Fakes.java`.
-
-Thus:
-
-* `bluetooth_adapter_android.h` owns:
- * `android/.../ChromeBluetoothAdapter.java` uses:
- * `android/.../Wrappers.java`: `BluetoothAdapterWrapper`
- * Which under test is a `FakeBluetoothAdapter`
- * `bluetooth_device_android.h` owns:
- * `android/.../ChromeBluetoothDevice.java` uses:
- * `android/.../Wrappers.java`: `BluetoothDeviceWrapper`
- * Which under test is a `FakeBluetoothDevice`
- * `bluetooth_gatt_service_android.h` owns:
- * `android/.../ChromeBluetoothService.java` uses:
- * `android/.../Wrappers.java`: `BluetoothServiceWrapper`
- * Which under test is a `FakeBluetoothService`
- * ... and so on for characteristics and descriptors.
-
-Fake objects are controlled by `bluetooth_test_android.cc`.
-
-See also: [Class Diagram of Web Bluetooth through Bluetooth Android][Class]
-
-[Class]: https://sites.google.com/a/chromium.org/dev/developers/design-documents/bluetooth-design-docs/web-bluetooth-through-bluetooth-android-class-diagram
-
+See [test/README.md](//device/bluetooth/test/README.md)
## Design Documents

Powered by Google App Engine
This is Rietveld 408576698