Chromium Code Reviews Chromium Code Reviews
Issue 2737343003:
bluetooth: Add FakeBluetooth interface (Closed)
| OLD | NEW |
|---|---|
| 1 # Bluetooth | 1 # Bluetooth |
| 2 | 2 |
| 3 `device/bluetooth` abstracts | 3 `device/bluetooth` abstracts |
| 4 [Bluetooth Classic](https://en.wikipedia.org/wiki/Bluetooth) and | 4 [Bluetooth Classic](https://en.wikipedia.org/wiki/Bluetooth) and |
| 5 [Low Energy](https://en.wikipedia.org/wiki/Bluetooth_low_energy) features | 5 [Low Energy](https://en.wikipedia.org/wiki/Bluetooth_low_energy) features |
| 6 across multiple platforms. | 6 across multiple platforms. |
| 7 | 7 |
| 8 Classic and Low Energy based profiles differ substantially. Platform | 8 Classic and Low Energy based profiles differ substantially. Platform |
| 9 implementations may support only one or the other, even though several classes | 9 implementations may support only one or the other, even though several classes |
| 10 have interfaces for both, e.g. `BluetoothAdapter` & `BluetoothDevice`. | 10 have interfaces for both, e.g. `BluetoothAdapter` & `BluetoothDevice`. |
| (...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 42 | 42 |
| 43 Known future work is tracked in the | 43 Known future work is tracked in the |
| 44 [Refactoring meta issue](https://crbug.com/580406). | 44 [Refactoring meta issue](https://crbug.com/580406). |
| 45 | 45 |
| 46 | 46 |
| 47 ## Testing | 47 ## Testing |
| 48 | 48 |
| 49 Implementation of the Bluetooth component is tested via unittests. Client code | 49 Implementation of the Bluetooth component is tested via unittests. Client code |
| 50 uses Mock Bluetooth objects: | 50 uses Mock Bluetooth objects: |
| 51 | 51 |
| 52 ### Mojo Testing Interface | |
| 53 A Mojo Testing Interface is defined at | |
| 54 `src/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom`. | |
| 55 Clients can use this interface to control a fake implementation of the non-mojo | |
| 56 C++ Bluetooth interface. The implementation of this test interface lives at | |
| 57 `src/device/bluetooth/test/`. | |
|
scheib
2017/04/08 00:59:50
Link to src/device/bluetooth/public/interfaces/tes
ortuno
2017/04/10 01:47:49
See reply in fake_bluetooth.mojom
ortuno
2017/04/12 05:49:06
Done.
| |
| 52 | 58 |
| 53 ### Cross Platform Unit Tests | 59 ### Cross Platform Unit Tests |
| 54 | 60 |
| 55 New feature development uses cross platform unit tests. This reduces test code | 61 New feature development uses cross platform unit tests. This reduces test code |
| 56 redundancy and produces consistency across all implementations. | 62 redundancy and produces consistency across all implementations. |
| 57 | 63 |
| 58 Unit tests operate at the public `device/bluetooth` API layer and the | 64 Unit tests operate at the public `device/bluetooth` API layer and the |
| 59 `BluetoothTest` fixture controls fake operating system behavior as close to the | 65 `BluetoothTest` fixture controls fake operating system behavior as close to the |
| 60 platfom as possible. The resulting test coverage spans the cross platform API, | 66 platfom as possible. The resulting test coverage spans the cross platform API, |
| 61 common implementation, and platform specific implementation as close to | 67 common implementation, and platform specific implementation as close to |
| (...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 129 See also: [Class Diagram of Web Bluetooth through Bluetooth Android][Class] | 135 See also: [Class Diagram of Web Bluetooth through Bluetooth Android][Class] |
| 130 | 136 |
| 131 [Class]: https://sites.google.com/a/chromium.org/dev/developers/design-documents /bluetooth-design-docs/web-bluetooth-through-bluetooth-android-class-diagram | 137 [Class]: https://sites.google.com/a/chromium.org/dev/developers/design-documents /bluetooth-design-docs/web-bluetooth-through-bluetooth-android-class-diagram |
| 132 | 138 |
| 133 | 139 |
| 134 ## Design Documents | 140 ## Design Documents |
| 135 | 141 |
| 136 * [Bluetooth Notifications](https://docs.google.com/document/d/1guBtAnQUP8ZoZre4 VQGrjR5uX0ZYxfK-lwKNeqY0-z4/edit?usp=sharing) 2016-08-26 | 142 * [Bluetooth Notifications](https://docs.google.com/document/d/1guBtAnQUP8ZoZre4 VQGrjR5uX0ZYxfK-lwKNeqY0-z4/edit?usp=sharing) 2016-08-26 |
| 137 * Web Bluetooth through Android implementation details, class diagram and | 143 * Web Bluetooth through Android implementation details, class diagram and |
| 138 call flow. | 144 call flow. |
| OLD | NEW |
