Allow dispatch to use a range of Class-ids in tests

runtime/vm/intermediate_language_arm.cc

 
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intermediate_language.h"
 
@@ skipping 6282 matching lines @@
   const Register value = locs()->in(0).reg();
   const Register temp = locs()->temp(0).reg();
   Label is_ok;
   if (unary_checks().GetReceiverClassIdAt(0) == kSmiCid) {
     __ tst(value, Operand(kSmiTagMask));
     __ b(&is_ok, EQ);
   } else {
     __ tst(value, Operand(kSmiTagMask));
     __ b(deopt, EQ);
   }
-  __ LoadClassId(temp, value);
+  Register biased_cid = temp;
+  __ LoadClassId(biased_cid, value);
 
-  if (IsDenseSwitch()) {
+  GrowableArray<CidRangeTarget> sorted_ic_data;
+  FlowGraphCompiler::SortICDataByCount(unary_checks(), &sorted_ic_data,
+                                       /* drop_smi = */ true);
+
+  if (sorted_ic_data.length() > 4 && IsDenseSwitch()) {

[Vyacheslav Egorov (Google), 2017/03/10 10:31:30]

What is this magical 4? Is this the same 4 as FLAG_max_polymorphic_checks

[erikcorry, 2017/03/10 13:30:01]

Accidental change, reverted.

     ASSERT(cids_[0] < cids_[cids_.length() - 1]);
-    __ AddImmediate(temp, -cids_[0]);
-    __ CompareImmediate(temp, cids_[cids_.length() - 1] - cids_[0]);
+    __ AddImmediate(biased_cid, -cids_[0]);
+    __ CompareImmediate(biased_cid, cids_[cids_.length() - 1] - cids_[0]);
     __ b(deopt, HI);
 
     intptr_t mask = ComputeCidMask();
     if (!IsDenseMask(mask)) {
       // Only need mask if there are missing numbers in the range.
       ASSERT(cids_.length() > 2);
       Register mask_reg = locs()->temp(1).reg();
       __ LoadImmediate(mask_reg, 1);
-      __ Lsl(mask_reg, mask_reg, temp);
+      __ Lsl(mask_reg, mask_reg, biased_cid);
       __ TestImmediate(mask_reg, mask);
       __ b(deopt, EQ);
     }
   } else {
-    GrowableArray<CidTarget> sorted_ic_data;
-    FlowGraphCompiler::SortICDataByCount(unary_checks(), &sorted_ic_data,
-                                         /* drop_smi = */ true);
     const intptr_t num_checks = sorted_ic_data.length();
+    int bias = 0;
     for (intptr_t i = 0; i < num_checks; i++) {
-      const intptr_t cid = sorted_ic_data[i].cid;
-      ASSERT(cid != kSmiCid);
-      __ CompareImmediate(temp, cid);
+      const intptr_t cid_start = sorted_ic_data[i].cid_start;
+      const intptr_t cid_end = sorted_ic_data[i].cid_end;
+      ASSERT(cid_start > kSmiCid || cid_end < kSmiCid);
+      Condition no_match, match;
+      if (cid_start == cid_end) {
+        __ CompareImmediate(biased_cid, cid_start - bias);
+        no_match = NE;
+        match = EQ;
+      } else {
+        // For class ID ranges use a subtract followed by an unsigned
+        // comparison to check both ends of the ranges with one comparison.
+        __ AddImmediate(biased_cid, biased_cid, bias - cid_start);
+        bias = cid_start;
+        __ CompareImmediate(biased_cid, cid_end - cid_start);
+        no_match = HI;  // Unsigned higher.
+        match = LS;     // Unsigned lower or same.
+      }
       if (i == (num_checks - 1)) {
-        __ b(deopt, NE);
+        __ b(deopt, no_match);
       } else {
-        __ b(&is_ok, EQ);
+        __ b(&is_ok, match);
       }
     }
   }
   __ Bind(&is_ok);
 }
 
 
 LocationSummary* CheckSmiInstr::MakeLocationSummary(Zone* zone,
                                                     bool opt) const {
   const intptr_t kNumInputs = 1;
@@ skipping 882 matching lines @@
   compiler->GenerateRuntimeCall(TokenPosition::kNoSource, deopt_id(),
                                 kGrowRegExpStackRuntimeEntry, 1, locs());
   __ Drop(1);
   __ Pop(result);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM