Allow dispatch to use a range of Class-ids in tests

runtime/vm/constants_dbc.h

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_CONSTANTS_DBC_H_
 #define RUNTIME_VM_CONSTANTS_DBC_H_
 
 #include "platform/globals.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 152 matching lines @@
 //
 //    Invoke native function SP[-1] with argc_tag SP[0].
 //
 //  - PushPolymorphicInstanceCall ArgC, D
 //
 //    Skips 2*D + 1 instructions and pushes a function object onto the stack
 //    if one can be found as follows. Otherwise skips only 2*D instructions.
 //    The function is looked up in the IC data encoded in the following 2*D
 //    Nop instructions. The Nop instructions should be arranged in pairs with
 //    the first being the cid, and the second being the function to push if
-//    the cid is the cid of the receiver found at SP[-(1 + ArgC)].
+//    the cid matches the cid in the pair.
+//
+//  - PushPolymorphic3InstanceCall ArgC, D

[Vyacheslav Egorov (Google), 2017/03/10 10:31:30]

Better call it 

PushPolymorphicInstanceCallByRange

(I think original instruction should have been called

PushPolymorphicInstanceCallTarget)

[erikcorry, 2017/03/10 13:30:01]

Done.

+//
+//    Skips 3*D + 1 instructions and pushes a function object onto the stack
+//    if one can be found as follows. Otherwise skips only 3*D instructions.
+//    The function is looked up in the IC data encoded in the following 3*D
+//    Nop instructions. The Nop instructions should be arranged in triples with
+//    the first being the start cid, the second being the number of cids, and
+//    the third being the function to push if the cid is in the range given
+//    by the first two Nop instructions.
 //
 //  - OneByteStringFromCharCode rA, rX
 //
 //    Load the one-character symbol with the char code given by the Smi
 //    in FP[rX] into FP[rA].
 //
 //  - StringToCharCode rA, rX
 //
 //    Load and smi-encode the single char code of the string in FP[rX] into
 //    FP[rA]. If the string's length is not 1, load smi -1 instead.
@@ skipping 399 matching lines @@
 //    a dense switch with low cid encoded in the following Nop instruction, and
 //    the cid mask encoded in the Nop instruction after that, or if D == 1 and
 //    FP[rA] is a Smi. Skips 2 instructions otherwise.
 //
 //  - CheckCids rA, rB, rC
 //
 //    Skips rC + 1 instructions if the object at FP[rA] is a Smi and
 //    rB == 1, or if FP[rA]'s cid is found in the array of cids encoded by the
 //    following rC Nop instructions. Otherwise skips only rC instructions.
 //
+//  - CheckCids2 rA, rB, rC

[Vyacheslav Egorov (Google), 2017/03/10 10:31:30]

Better call it CheckCidRanges

[erikcorry, 2017/03/10 13:30:01]

Done.

+//
+//    Skips rC + 1 instructions if the object at FP[rA] is a Smi and rB ==
+//    1, or if FP[rA]'s cid is found in the array of cid ranges encoded by the
+//    following rC Nop instructions. The cid ranges from a inclusive to b
+//    exclusive are coded in pairs of (a, b - a). Otherwise skips only 2
+//    instructions.
+//
 //  - CheckStack
 //
 //    Compare SP against isolate stack limit and call StackOverflow handler if
 //    necessary.
 //
 //  - DebugStep, DebugBreak A
 //
 //    Debugger support. DebugBreak is bytecode that can be patched into the
 //    instruction stream to trigger in place breakpoint.
 //
@@ skipping 68 matching lines @@
   V(PushConstant,                    D, lit, ___, ___) \
   V(StoreLocal,                      X, xeg, ___, ___) \
   V(PopLocal,                        X, xeg, ___, ___) \
   V(IndirectStaticCall,            A_D, num, num, ___) \
   V(StaticCall,                    A_D, num, num, ___) \
   V(InstanceCall1,                 A_D, num, num, ___) \
   V(InstanceCall2,                 A_D, num, num, ___) \
   V(InstanceCall1Opt,              A_D, num, num, ___) \
   V(InstanceCall2Opt,              A_D, num, num, ___) \
   V(PushPolymorphicInstanceCall,   A_D, num, num, ___) \
+  V(PushPolymorphic3InstanceCall,  A_D, num, num, ___) \
   V(NativeCall,                      0, ___, ___, ___) \
   V(NativeBootstrapCall,             0, ___, ___, ___) \
   V(OneByteStringFromCharCode,     A_X, reg, xeg, ___) \
   V(StringToCharCode,              A_X, reg, xeg, ___) \
   V(AddTOS,                          0, ___, ___, ___) \
   V(SubTOS,                          0, ___, ___, ___) \
   V(MulTOS,                          0, ___, ___, ___) \
   V(BitOrTOS,                        0, ___, ___, ___) \
   V(BitAndTOS,                       0, ___, ___, ___) \
   V(EqualTOS,                        0, ___, ___, ___) \
@@ skipping 122 matching lines @@
   V(BadTypeError,                    0, ___, ___, ___) \
   V(AssertAssignable,              A_D, num, lit, ___) \
   V(AssertBoolean,                   A, num, ___, ___) \
   V(TestSmi,                       A_D, reg, reg, ___) \
   V(TestCids,                      A_D, reg, num, ___) \
   V(CheckSmi,                        A, reg, ___, ___) \
   V(CheckEitherNonSmi,             A_D, reg, reg, ___) \
   V(CheckClassId,                  A_D, reg, num, ___) \
   V(CheckDenseSwitch,              A_D, reg, num, ___) \
   V(CheckCids,                   A_B_C, reg, num, num) \
+  V(CheckCids2,                  A_B_C, reg, num, num) \
   V(CheckStack,                      0, ___, ___, ___) \
   V(CheckStackAlwaysExit,            0, ___, ___, ___) \
   V(DebugStep,                       0, ___, ___, ___) \
   V(DebugBreak,                      A, num, ___, ___) \
   V(Deopt,                         A_D, num, num, ___) \
   V(DeoptRewind,                     0, ___, ___, ___)
 
 // clang-format on
 
 typedef uint32_t Instr;
@@ skipping 130 matching lines @@
 
 // After a comparison, the condition NEXT_IS_TRUE means the following
 // instruction is executed if the comparision is true and skipped over overwise.
 // Conidition NEXT_IS_FALSE means the following instruction is executed if the
 // comparison is false and skipped over otherwise.
 enum Condition { NEXT_IS_TRUE, NEXT_IS_FALSE };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_CONSTANTS_DBC_H_