components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java - Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java

Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler (Closed)

Patch Set: Fully implemented, still needs tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java ('K') | « components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java ('k') | components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java

diff --git a/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java

index 78c8b9d53f2a97ff02d781da1725c00f4c36e8be..f91190343c490525d24a1bee0eb23baae3c46f07 100644

--- a/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java

+++ b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java

@@ -99,7 +99,6 @@ public class CrashTestCase extends InstrumentationTestCase {

public static class MockCrashReportingPermissionManager

implements CrashReportingPermissionManager {

protected boolean mIsInSample;

- protected boolean mIsPermitted;

protected boolean mIsUserPermitted;

protected boolean mIsCommandLineDisabled;

protected boolean mIsNetworkAvailable;

@@ -118,11 +117,6 @@ public class CrashTestCase extends InstrumentationTestCase {

}

@Override

- public boolean isMetricsUploadPermitted() {

- return mIsPermitted;

- }

- @Override

public boolean isUsageAndCrashReportingPermittedByUser() {

return mIsUserPermitted;

}