[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java

Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
index 59498838c060481cce6e17a96996cef4941f2e26..5d05c12c2472ca295f655679d1e9f34767664725 100644
--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
@@ -23,14 +23,8 @@ public interface CrashReportingPermissionManager {
      */
     public boolean isNetworkAvailableForCrashUploads();
 
-    /**
-     * Checks whether uploading of crash dumps is permitted, based on the corresponding command line
-     * flag only.
-     *
-     * @return whether uploading of crash dumps is enabled or disabled by a command line flag.
-     */
-    public boolean isCrashUploadDisabledByCommandLine();
-
+    // TODO(isherman): Remove this function. It's only used for an assertion, and our JobService
+    // implementations simply hardcode their return value to true.
     /**
      * Checks whether uploading of usage metrics is currently permitted. This is a combination of
      * the below checks, plus networking restrictions.
@@ -39,6 +33,18 @@ public interface CrashReportingPermissionManager {
      */
     public boolean isMetricsUploadPermitted();
 
+    // TODO(isherman): Remove this function. It was previously used to enable a specific type of
+    // test, but it should not be necessary anymore. (Note: There are currently some clients that do
+    // partly depend on it, so it is not necessarily safe to remove without contacting those
+    // clients.)
+    /**
+     * Checks whether uploading of crash dumps is permitted, based on the corresponding command line
+     * flag only.
+     *
+     * @return whether uploading of crash dumps is enabled or disabled by a command line flag.
+     */
+    public boolean isCrashUploadDisabledByCommandLine();
+
     /**
      * Checks whether uploading of usage metrics and crash dumps is currently permitted, based on
      * user consent only.