Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/browser/android/chrome_feature_list.cc

Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler (Closed)
Patch Set: Use shared prefs Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/chrome_feature_list.h" 5 #include "chrome/browser/android/chrome_feature_list.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 &kNTPFakeOmniboxTextFeature, 60 &kNTPFakeOmniboxTextFeature,
61 &kNTPLaunchAfterInactivity, 61 &kNTPLaunchAfterInactivity,
62 &kNTPOfflinePagesFeature, 62 &kNTPOfflinePagesFeature,
63 &NTPShowGoogleGInOmniboxFeature, 63 &NTPShowGoogleGInOmniboxFeature,
64 &kPhysicalWebFeature, 64 &kPhysicalWebFeature,
65 &kPhysicalWebSharing, 65 &kPhysicalWebSharing,
66 &kSpecialLocaleFeature, 66 &kSpecialLocaleFeature,
67 &kSpecialLocaleWrapper, 67 &kSpecialLocaleWrapper,
68 &kTabsInCBD, 68 &kTabsInCBD,
69 &kTabReparenting, 69 &kTabReparenting,
70 &kUploadCrashReportsUsingJobScheduler,
70 &kWebPaymentsModifiers, 71 &kWebPaymentsModifiers,
71 &kWebPaymentsSingleAppUiSkip, 72 &kWebPaymentsSingleAppUiSkip,
72 &kWebVRCardboardSupport, 73 &kWebVRCardboardSupport,
73 &ntp_snippets::kIncreasedVisibility, 74 &ntp_snippets::kIncreasedVisibility,
74 &ntp_snippets::kForeignSessionsSuggestionsFeature, 75 &ntp_snippets::kForeignSessionsSuggestionsFeature,
75 &ntp_snippets::kOfflineBadgeFeature, 76 &ntp_snippets::kOfflineBadgeFeature,
76 &ntp_snippets::kSaveToOfflineFeature, 77 &ntp_snippets::kSaveToOfflineFeature,
77 &offline_pages::kBackgroundLoaderForDownloadsFeature, 78 &offline_pages::kBackgroundLoaderForDownloadsFeature,
78 &offline_pages::kOfflinePagesCTFeature, // See crbug.com/620421. 79 &offline_pages::kOfflinePagesCTFeature, // See crbug.com/620421.
79 &offline_pages::kOfflinePagesSharingFeature, 80 &offline_pages::kOfflinePagesSharingFeature,
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 base::FEATURE_DISABLED_BY_DEFAULT}; 166 base::FEATURE_DISABLED_BY_DEFAULT};
166 167
167 const base::Feature kSpecialLocaleWrapper{"SpecialLocaleWrapper", 168 const base::Feature kSpecialLocaleWrapper{"SpecialLocaleWrapper",
168 base::FEATURE_ENABLED_BY_DEFAULT}; 169 base::FEATURE_ENABLED_BY_DEFAULT};
169 170
170 const base::Feature kTabsInCBD{"TabsInCBD", base::FEATURE_DISABLED_BY_DEFAULT}; 171 const base::Feature kTabsInCBD{"TabsInCBD", base::FEATURE_DISABLED_BY_DEFAULT};
171 172
172 const base::Feature kTabReparenting{"TabReparenting", 173 const base::Feature kTabReparenting{"TabReparenting",
173 base::FEATURE_ENABLED_BY_DEFAULT}; 174 base::FEATURE_ENABLED_BY_DEFAULT};
174 175
176 // TODO(isherman): Switch this to be disabled by default instead.
177 // TODO(isherman): Write tests for both feature flag states.
Maria 2017/03/14 19:03:32 Is this todo for before submitting this change?
Ilya Sherman 2017/03/15 02:13:35 Yep. Done.
178 const base::Feature kUploadCrashReportsUsingJobScheduler{
179 "UploadCrashReportsUsingJobScheduler", base::FEATURE_ENABLED_BY_DEFAULT};
180
175 const base::Feature kUserMediaScreenCapturing{ 181 const base::Feature kUserMediaScreenCapturing{
176 "UserMediaScreenCapturing", base::FEATURE_DISABLED_BY_DEFAULT}; 182 "UserMediaScreenCapturing", base::FEATURE_DISABLED_BY_DEFAULT};
177 183
178 const base::Feature kWebPaymentsModifiers{"WebPaymentsModifiers", 184 const base::Feature kWebPaymentsModifiers{"WebPaymentsModifiers",
179 base::FEATURE_DISABLED_BY_DEFAULT}; 185 base::FEATURE_DISABLED_BY_DEFAULT};
180 186
181 const base::Feature kWebPaymentsSingleAppUiSkip{ 187 const base::Feature kWebPaymentsSingleAppUiSkip{
182 "WebPaymentsSingleAppUiSkip", base::FEATURE_ENABLED_BY_DEFAULT}; 188 "WebPaymentsSingleAppUiSkip", base::FEATURE_ENABLED_BY_DEFAULT};
183 189
184 const base::Feature kWebVRCardboardSupport{ 190 const base::Feature kWebVRCardboardSupport{
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name, 249 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name,
244 jdefault_value); 250 jdefault_value);
245 } 251 }
246 252
247 bool RegisterChromeFeatureListJni(JNIEnv* env) { 253 bool RegisterChromeFeatureListJni(JNIEnv* env) {
248 return RegisterNativesImpl(env); 254 return RegisterNativesImpl(env);
249 } 255 }
250 256
251 } // namespace android 257 } // namespace android
252 } // namespace chrome 258 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698