Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: build/android/pylib/utils/google_storage_helper.py

Issue 2737223002: Revert of Add failure screenshots and render test images to results detail. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/utils/google_storage_helper.py
diff --git a/build/android/pylib/utils/google_storage_helper.py b/build/android/pylib/utils/google_storage_helper.py
deleted file mode 100644
index 2fbbc1513ebc5aa8ea9701b9edc3ab63645c4b75..0000000000000000000000000000000000000000
--- a/build/android/pylib/utils/google_storage_helper.py
+++ /dev/null
@@ -1,57 +0,0 @@
-# Copyright 2017 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Helper functions to upload data to Google Storage.
-
-Text data should be streamed to logdog using |logdog_helper| module.
-Due to logdog not having image or HTML viewer, those instead should be uploaded
-to Google Storage directly using this module.
-"""
-
-import logging
-import os
-import sys
-import time
-
-from devil.utils import cmd_helper
-from pylib.constants import host_paths
-from pylib.utils import decorators
-
-sys.path.append(os.path.join(host_paths.DIR_SOURCE_ROOT, 'build'))
-import find_depot_tools # pylint: disable=import-error
-
-_URL_TEMPLATE = 'https://storage.googleapis.com/%s/'
-
-
-@decorators.NoRaiseException(default_return_value='')
-def upload(name, filepath, bucket):
- """Uploads data to Google Storage.
-
- Args:
- name: Name of the file on Google Storage.
- filepath: Path to file you want to upload.
- bucket: Bucket to upload file to.
- """
- gs_path = os.path.join('gs://%s/' % bucket, name)
- logging.info('Uploading %s to %s', filepath, gs_path)
- cmd_helper.RunCmd(
- [os.path.join(find_depot_tools.DEPOT_TOOLS_PATH, 'gsutil.py'), 'cp',
- filepath, gs_path])
-
- return os.path.join(_URL_TEMPLATE % bucket, name)
-
-
-def unique_name(basename, timestamp=True, device=None):
- """Helper function for creating a unique name for a logdog stream.
-
- Args:
- basename: Base of the unique name.
- timestamp: Whether or not to add a timestamp to name.
- device: Device to add device serial of to name.
- """
- return '%s%s%s' % (
- basename,
- '_%s' % time.strftime('%Y%m%dT%H%M%S', time.localtime())
- if timestamp else '',
- '_%s' % device.serial if device else '')
« no previous file with comments | « build/android/pylib/local/device/local_device_instrumentation_test_run.py ('k') | build/android/pylib/utils/logdog_helper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698