Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: base/trace_event/memory_dump_manager_unittest.cc

Issue 2737153002: [memory-infra] Implement peak detection logic (Closed)
Patch Set: nit. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/memory_dump_scheduler.h » ('j') | base/trace_event/memory_dump_scheduler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager_unittest.cc
diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc
index 51d41943fba0416fd9ad5f167d78cbbbdbc51a1c..a7d952e39dc6fa21bd9cdb9250892f568805016a 100644
--- a/base/trace_event/memory_dump_manager_unittest.cc
+++ b/base/trace_event/memory_dump_manager_unittest.cc
@@ -770,7 +770,7 @@ TEST_F(MemoryDumpManagerTest, TestPollingOnDumpThread) {
ThreadTaskRunnerHandle::Get();
auto quit_closure = run_loop.QuitClosure();
- const int kPollsToQuit = 10;
+ const int kPollsToQuit = 60;
Primiano Tucci (use gerrit) 2017/03/10 10:19:32 out of curiosity, why? isn't this going to make th
ssid 2017/03/10 19:49:01 Thought more about it and it does not help the tes
int call_count = 0;
MemoryDumpManager* mdm = mdm_.get();
const auto poll_function1 = [&call_count, &test_task_runner, quit_closure,
« no previous file with comments | « no previous file | base/trace_event/memory_dump_scheduler.h » ('j') | base/trace_event/memory_dump_scheduler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698