[memory-infra] Implement peak detection logic

base/trace_event/memory_dump_scheduler.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_SCHEDULER_H
 #define BASE_TRACE_EVENT_MEMORY_DUMP_SCHEDULER_H
 
+#include <deque>
+
 #include "base/base_export.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/timer/timer.h"
 #include "base/trace_event/memory_dump_request_args.h"
 
 namespace base {
 class SingleThreadTaskRunner;
 
 namespace trace_event {
@@ skipping 60 matching lines @@
 
     scoped_refptr<SingleThreadTaskRunner> polling_task_runner;
     uint32_t polling_interval_ms;
 
     // Minimum numer of polls after the last dump at which next dump can be
     // triggered.
     int min_polls_between_dumps;
     int num_polls_from_last_dump;
 
     uint64_t last_dump_memory_total;
+    int64_t memory_increase_threshold;
+    std::deque<uint64_t> last_n_memory_totals;

[Primiano Tucci (use gerrit), 2017/03/09 18:31:27]

I'd drop the "_n" in the name

[Primiano Tucci (use gerrit), 2017/03/09 18:31:27]

also deque is super silly memory-wise, as dskiba found out, in some platforms
allocated 4k pages, which is a waste here.
I think a better approach here would be:
- Have a flat array uint32_t
last_memory_samples[kNumTotalsTrackedForPeakDetection];
- Have a uint32_t last_memory_samples_index;

When you write them in the buffer just do:
last_memory_samples[index] = GetMemory()
index = (index + 1) % kNumTotals
 
When you compute the average/stddev just exclude the values with 0, because you
know that 0 is never a valid value.

[ssid, 2017/03/09 19:32:44]

I didn't want to re-implement deque here and code looks complicated. It will
save few hundred bytes i guess.

[ssid, 2017/03/09 19:32:44]

Done.

 
     DISALLOW_COPY_AND_ASSIGN(PollingTriggerState);
   };
 
   // Helper to set polling disabled on the polling thread.
   void DisablePolling();
 
   // Periodically called by the timer.
   void RequestPeriodicGlobalDump();
 
   // Called for polling memory usage and trigger dumps if peak is detected.
   void PollMemoryOnPollingThread();
 
   // Returns true if peak memory value is detected.
   bool ShouldTriggerDump(uint64_t current_memory_total);
 
+  // Helper to detect peaks in memory usage.
+  bool IsCurrentSamplePeak(uint64_t current_memory_total);
+
   // Must be set before enabling tracing.
   static void SetPollingIntervalForTesting(uint32_t interval);
 
   // True if periodic dumping is enabled.
   bool IsPeriodicTimerRunningForTesting();
 
   MemoryDumpManager* mdm_;
 
   PeriodicTriggerState periodic_state_;
   PollingTriggerState polling_state_;
 
+  // Total physical memory of the device.
+  size_t total_physical_memory_;

[Primiano Tucci (use gerrit), 2017/03/09 18:31:27]

I find this a bit of a misleading name, because I can't tell whether this is the
"total amount of system memory"  or "amount of system memory used" or "total
memory used by chrome". I think the 1st, but would be great to  clarify.

[ssid, 2017/03/09 19:32:44]

sorry, mistake. Removed this field.

+
   DISALLOW_COPY_AND_ASSIGN(MemoryDumpScheduler);
 };
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_MEMORY_DUMP_SCHEDULER_H