Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: content/browser/download/parallel_download_utils_unittest.cc

Issue 2737033002: Update the received slices vector when stream is written to disk (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/parallel_download_utils_unittest.cc
diff --git a/content/browser/download/parallel_download_utils_unittest.cc b/content/browser/download/parallel_download_utils_unittest.cc
index abab9428a6c8786ea138d6e008086c47408fcb04..cc2c9e11887f5cc0b962625fab2d1f709def1a34 100644
--- a/content/browser/download/parallel_download_utils_unittest.cc
+++ b/content/browser/download/parallel_download_utils_unittest.cc
@@ -39,4 +39,25 @@ TEST(ParallelDownloadUtilsTest, FindNextSliceToDownload) {
EXPECT_EQ(500, slice.received_bytes);
}
+TEST(ParallelDownloadUtilsTest, AddReceivedSliceToSortedArray) {
+ std::vector<DownloadItem::ReceivedSlice> slices;
+ DownloadItem::ReceivedSlice slice1(500, 500);
+ EXPECT_EQ(0, AddReceivedSliceToSortedArray(slice1, slices));
+ EXPECT_EQ(1u, slices.size());
+ EXPECT_EQ(slice1, slices[0]);
+
+ DownloadItem::ReceivedSlice slice2(1000, 400);
+ EXPECT_EQ(1, AddReceivedSliceToSortedArray(slice2, slices));
+ EXPECT_EQ(2u, slices.size());
+ EXPECT_EQ(slice1, slices[0]);
+ EXPECT_EQ(slice2, slices[1]);
+
+ DownloadItem::ReceivedSlice slice3(0, 50);
+ EXPECT_EQ(0, AddReceivedSliceToSortedArray(slice3, slices));
+ EXPECT_EQ(3u, slices.size());
+ EXPECT_EQ(slice3, slices[0]);
+ EXPECT_EQ(slice1, slices[1]);
+ EXPECT_EQ(slice2, slices[2]);
xingliu 2017/03/07 22:18:13 nit%: Can we add another case here that inserts so
qinmin 2017/03/08 18:46:33 Done.
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698