Update the received slices vector when stream is written to disk

content/browser/download/download_file_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_file_impl.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "content/browser/byte_stream.h"
 #include "content/browser/download/download_create_info.h"
 #include "content/browser/download/download_destination_observer.h"
 #include "content/browser/download/download_interrupt_reasons_impl.h"
 #include "content/browser/download/download_net_log_parameters.h"
 #include "content/browser/download/download_stats.h"
+#include "content/browser/download/parallel_download_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "crypto/secure_hash.h"
 #include "crypto/sha2.h"
 #include "net/base/io_buffer.h"
 #include "net/log/net_log.h"
 #include "net/log/net_log_event_type.h"
 #include "net/log/net_log_source.h"
 #include "net/log/net_log_source_type.h"
 
 namespace content {
 
 const int kUpdatePeriodMs = 500;
 const int kMaxTimeBlockingFileThreadMs = 1000;
 
 // These constants control the default retry behavior for failing renames. Each
 // retry is performed after a delay that is twice the previous delay. The
 // initial delay is specified by kInitialRenameRetryDelayMs.
 const int kInitialRenameRetryDelayMs = 200;
 
 // Number of times a failing rename is retried before giving up.
 const int kMaxRenameRetries = 3;
 
 DownloadFileImpl::SourceStream::SourceStream(int64_t offset, int64_t length)
-    : offset_(offset), length_(length), bytes_written_(0), finished_(false) {}
+    : offset_(offset),
+      length_(length),
+      bytes_written_(0),
+      finished_(false),
+      index_(0u) {}
 
 DownloadFileImpl::SourceStream::~SourceStream() = default;
 
 void DownloadFileImpl::SourceStream::SetByteStream(
     std::unique_ptr<ByteStreamReader> stream_reader) {
   stream_reader_ = std::move(stream_reader);
 }
 
 void DownloadFileImpl::SourceStream::OnWriteBytesToDisk(int64_t bytes_write) {
   bytes_written_ += bytes_write;
@@ skipping 249 matching lines @@
             should_terminate = true;
             incoming_data_size =
                 source_stream->length() - source_stream->bytes_written();
           }
           reason = WriteDataToFile(
               source_stream->offset() + source_stream->bytes_written(),
               incoming_data.get()->data(), incoming_data_size);
           disk_writes_time_ += (base::TimeTicks::Now() - write_start);
           bytes_seen_ += incoming_data_size;
           total_incoming_data_size += incoming_data_size;
-          if (reason == DOWNLOAD_INTERRUPT_REASON_NONE)
+          if (reason == DOWNLOAD_INTERRUPT_REASON_NONE) {
+            int64_t prev_bytes_written = source_stream->bytes_written();
             source_stream->OnWriteBytesToDisk(incoming_data_size);
+            // If the write operation creates a new slice, add it to the

[David Trainor- moved to gerrit, 2017/03/09 17:44:02]

Move this comment after the if (!is_sparse_file_)?

[qinmin, 2017/03/09 21:44:58]

Done.

+            // |received_slices_| and update all the entries in
+            // |source_streams_|.
+            if (!is_sparse_file_)

[David Trainor- moved to gerrit, 2017/03/09 17:44:02]

Starting to wonder if in the future we should consider treating a
!is_sparse_file_ as a is_sparse_file_ with a single slice and remove the
boolean.

[qinmin, 2017/03/09 21:44:58]

updated the TODO in the header file. There could still be some issues in
calculating the hash in BaseFile, we need to figure that out first.

+              break;
+            if (incoming_data_size > 0 && prev_bytes_written == 0) {
+              AddNewSlice(source_stream->offset(), incoming_data_size);
+            } else {
+              received_slices_[source_stream->index()].received_bytes +=

[David Trainor- moved to gerrit, 2017/03/09 17:44:02]

Should the stream just hold a reference to the associated slice directly?  Feels
like that would clean some of this up.

[qinmin, 2017/03/09 21:44:58]

Hold a pointer/reference is not safe when the |received_slice_| vector changes.
Index is much easier to update when the vector changes, just +/-1 or don't
change.  But for pointers/references, we need to recalculate the slice pointer
for each source stream.

+                  incoming_data_size;
+            }
+          }
         }
         break;
       case ByteStreamReader::STREAM_COMPLETE:
         {
           reason = static_cast<DownloadInterruptReason>(
             source_stream->stream_reader()->GetStatus());
           SendUpdate();
         }
         break;
       default:
@@ skipping 99 matching lines @@
 
 void DownloadFileImpl::WillWriteToDisk(size_t data_len) {
   if (!update_timer_->IsRunning()) {
     update_timer_->Start(FROM_HERE,
                          base::TimeDelta::FromMilliseconds(kUpdatePeriodMs),
                          this, &DownloadFileImpl::SendUpdate);
   }
   rate_estimator_.Increment(data_len);
 }
 
+void DownloadFileImpl::AddNewSlice(int64_t offset, int64_t length) {
+  if (!is_sparse_file_)
+    return;
+  size_t index = AddOrMergeReceivedSliceIntoSortedArray(
+      DownloadItem::ReceivedSlice(offset, length), received_slices_);
+  // Check if the slice is added as a new slice, or merged with an existing one.
+  bool slice_added = (offset == received_slices_[index].offset);
+  // Update the index of exising SourceStreams.
+  for (auto& stream : source_streams_) {
+    SourceStream* source_stream = stream.second.get();
+    if (source_stream->offset() > offset) {
+      if (slice_added && source_stream->bytes_written() > 0)
+        source_stream->set_index(source_stream->index() + 1);
+    } else if (source_stream->offset() == offset) {
+      source_stream->set_index(index);
+    } else if (source_stream->length() ==
+                   DownloadSaveInfo::kLengthFullContent ||
+               source_stream->length() > offset - source_stream->offset()) {
+      // The newly introduced slice will impact the length of the SourceStreams
+      // preceding it.
+      source_stream->set_length(offset - source_stream->offset());
+    }
+  }
+}
+
 DownloadFileImpl::RenameParameters::RenameParameters(
     RenameOption option,
     const base::FilePath& new_path,
     const RenameCompletionCallback& completion_callback)
     : option(option),
       new_path(new_path),
       retries_left(kMaxRenameRetries),
       completion_callback(completion_callback) {}
 
 DownloadFileImpl::RenameParameters::~RenameParameters() {}
 
 }  // namespace content