Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/tools.gyp

Issue 273703006: extract some common code from PictureRenderer (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: forgot to add these files Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gm/gm_expectations.cpp ('K') | « gyp/gm.gyp ('k') | gyp/utils.gyp » ('j') | tools/PictureRenderer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/tools.gyp
diff --git a/gyp/tools.gyp b/gyp/tools.gyp
index 769cf6cd2fcb7690e1d26a93e962a05ab3b48c2d..e3ed7d5d410c9e8062373647a1f65c9f4f1265a6 100644
--- a/gyp/tools.gyp
+++ b/gyp/tools.gyp
@@ -369,6 +369,8 @@
'target_name': 'picture_renderer',
'type': 'static_library',
'sources': [
+ '../tools/image_expectations.h',
+ '../tools/image_expectations.cpp',
'../tools/LazyDecodeBitmap.cpp',
'../tools/PictureRenderer.h',
'../tools/PictureRenderer.cpp',
@@ -388,7 +390,7 @@
],
'direct_dependent_settings': {
'include_dirs': [
- # needed for JSON headers used within PictureRenderer.h
+ # needed for JSON headers used within image_expectations.h
'../third_party/externals/jsoncpp-chromium/overrides/include/',
'../third_party/externals/jsoncpp/include/',
],
@@ -398,6 +400,7 @@
'jsoncpp.gyp:jsoncpp',
'skia_lib.gyp:skia_lib',
'tools.gyp:picture_utils',
+ 'utils.gyp:utils',
],
'conditions': [
['skia_gpu == 1',
« gm/gm_expectations.cpp ('K') | « gyp/gm.gyp ('k') | gyp/utils.gyp » ('j') | tools/PictureRenderer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698