Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/dev/gm.py

Issue 2736923002: SnapshotCreator: start from existing snapshot if we have one (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/wasm/test-run-wasm-module.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dev/gm.py
diff --git a/tools/dev/gm.py b/tools/dev/gm.py
index 9e6136833890cd395763c9f0d06c77693ff3e9ad..2f41b614b095f45af058661073891e4aac4dfc0c 100755
--- a/tools/dev/gm.py
+++ b/tools/dev/gm.py
@@ -288,8 +288,9 @@ def Main(argv):
return_code = 0
for c in configs:
return_code += configs[c].Build()
- for c in configs:
- return_code += configs[c].RunTests()
+ if return_code == 0:
+ for c in configs:
+ return_code += configs[c].RunTests()
if return_code == 0:
_Call("notify-send 'Done!' 'V8 compilation finished successfully.'",
silent=True)
« no previous file with comments | « test/cctest/wasm/test-run-wasm-module.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698