tools/dev/gm.py - Issue 2736923002: SnapshotCreator: start from existing snapshot if we have one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dev/gm.py

Issue 2736923002: SnapshotCreator: start from existing snapshot if we have one (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dev/gm.py

diff --git a/tools/dev/gm.py b/tools/dev/gm.py

index 9e6136833890cd395763c9f0d06c77693ff3e9ad..2f41b614b095f45af058661073891e4aac4dfc0c 100755

--- a/tools/dev/gm.py

+++ b/tools/dev/gm.py

@@ -288,8 +288,9 @@ def Main(argv):

return_code = 0

for c in configs:

return_code += configs[c].Build()

- for c in configs:

- return_code += configs[c].RunTests()

+ if return_code == 0:

Yang 2017/03/07 11:28:11 Is this a stray edit or intentional drive-by fix?

Jakob Kummerow 2017/03/07 12:39:15 Intentional fix. Running tests doesn't make sense

+ for c in configs:

+ return_code += configs[c].RunTests()

if return_code == 0:

_Call("notify-send 'Done!' 'V8 compilation finished successfully.'",

silent=True)

« src/snapshot/snapshot.h ('K') | « test/cctest/wasm/test-run-wasm-module.cc ('k') | no next file » | no next file with comments »