SnapshotCreator: start from existing snapshot if we have one

src/snapshot/snapshot.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_SNAPSHOT_SNAPSHOT_H_
 #define V8_SNAPSHOT_SNAPSHOT_H_
 
 #include "src/snapshot/partial-serializer.h"
 #include "src/snapshot/startup-serializer.h"
 
@@ skipping 21 matching lines @@
   Vector<const byte> Payload() const;
 
   Vector<const byte> RawData() const {
     return Vector<const byte>(data_, size_);
   }
 
  private:
   bool IsSane();
 
   // The data header consists of uint32_t-sized entries:
-  // [0] magic number and external reference count
-  // [1] version hash
-  // [2] number of reservation size entries
-  // [3] payload length
+  // [0] magic number and (internal) external reference count
+  // [1] API-provided external reference count
+  // [2] version hash
+  // [3] number of reservation size entries
+  // [4] payload length
   // ... reservations
   // ... serialized payload
-  static const int kCheckSumOffset = kMagicNumberOffset + kInt32Size;
+  static const int kCheckSumOffset =

[Yang, 2017/03/07 11:28:11]

Now that I see it, this name is a bit misleading. Can we either call this
kVersionHashOffset, or move this and the one in SerializedCodeData into
SerializedData?

[Jakob Kummerow, 2017/03/07 12:39:15]

Done (moved).

+      kExtraExternalReferencesOffset + kInt32Size;
   static const int kNumReservationsOffset = kCheckSumOffset + kInt32Size;
   static const int kPayloadLengthOffset = kNumReservationsOffset + kInt32Size;
   static const int kHeaderSize = kPayloadLengthOffset + kInt32Size;
 };
 
 class Snapshot : public AllStatic {
  public:
   // Initialize the Isolate from the internal snapshot. Returns false if no
   // snapshot could be found.
   static bool Initialize(Isolate* isolate);
@@ skipping 52 matching lines @@
 };
 
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
 void SetSnapshotFromFile(StartupData* snapshot_blob);
 #endif
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_SNAPSHOT_SNAPSHOT_H_